Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't read chapters defined in moov.udata.chpl #69

Open
danhi opened this issue Mar 27, 2022 · 3 comments
Open

Doesn't read chapters defined in moov.udata.chpl #69

danhi opened this issue Mar 27, 2022 · 3 comments

Comments

@danhi
Copy link

danhi commented Mar 27, 2022

While there is code that should read the chpl atom in moov.udata.chpl, it doesn't seem to work. Also the MP4GetChapters function doesn't seem to look for this. It would be great if MP4GetChapters would use the chpl data if the text track wasn't found.
@enzo1982
Copy link

Chapters in moov.udta.chpl are Nero chapters. MP4GetChapters reads only QuickTime chapters by default. To read Nero chapters, pass MP4ChapterTypeNero or MP4ChapterTypeAny as the 4th argument.

By the way, consider using the MP4v2 library from mp4v2.org resp. enzo1982/mp4v2. That's my attempt to revive the MP4v2 project and continue active development.

@danhi
Copy link
Author

danhi commented Mar 27, 2022 via email

@enzo1982
Copy link

I’ll have to check it out, because I’ve been maintaining my own private version for a while now, so I’ll have to figure out what changes I’ve made and if they would be acceptable in a public version.

Great! If you have any changes that you think would be good to have in the public version, feel free to open pull requests on enzo1982/mp4v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danhi @enzo1982