Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

[1.12.2] RecipeHandler findAndApply method ignores NBT for chemical reactor and centrifuge #162

Open
skyline918 opened this issue Aug 27, 2020 · 1 comment

Comments

@skyline918
Copy link

skyline918 commented Aug 27, 2020

Hello, this issue related to https://github.com/TechReborn/TechReborn/issues/2182 , but there was no activity for 30 days. The point is one can use any type of cells in these machines (even empty ones), and crafting starts anyway, using first matching recipe with available count. I surrounded Recipe recipe = recipeHandler.findAndApply(inputs, true); (https://github.com/TechReborn/TechReborn/blob/614e10c280fe71b9d457ed6037026196e0441dac/src/main/java/techreborn/tiles/processing/TileMachine.java#L189) with prints , and wrong recipe was found on runtime.

TR: 2.27.3 (cloned from branch 1.12)
RC: 3.19.4.529

image

@MerrittK
Copy link

MerrittK commented Dec 2, 2020

They released a build in may where they said they fixed it on the 1.12 branch. But this is still an issue now.
TechReborn/TechReborn@698dfee

It effectively breaks tech reborn on 1.12 entirely, since the unaffected machines are duplicating IC2 functionality already.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants