[1.21.11 - 6.0.0] Cant use Controlify mod with JourneyMap

[pburkett]

What happened?

Hello, I'm attempting to use Controlify (java controller mod) and journeymap together. Unfortunately, controller inputs for journeymap dont seem to work. I am able to bind controller inputs to controls for other mods successfully, but journeymap doesnt seem to support it.

I've also asked Controlify support about this. So far Ive gotten this feedback:

might be a problem with journeymap if it doesn’t use the standard Minecraft/ APIs for getting input, if it looks at keys directly, it won’t pick up controlify’s injected button events

Let me know if you have ideas!

Mod Loader

Fabric

Minecraft Version

other (please list)

Version

6.0.0-beta.x - Specify Beta version

Relevant log output

journeymap.log
latest.log

[isXander]

Afaik JourneyMap uses key press events and checks if the bound key to a KeyMapping matches. This is not the correct way to do this.

You should instead subscribe to the on tick event, and use something like

while (openMapKey.wasPressed()) {
    openMap()
}

this is how the vanilla game does all key mapping stuff.

Controlify injects key presses directly into KeyMappings like this. It does not send fake key presses into the vanilla pipeline.

[mysticdrew]

@isXander
That does not seem to work while a screen is open though, the isDown flag is not getting set to true on the keymapping.

Controller keys presses are also not getting passed through fabric's ScreenKeyboardEvents.allowKeyPress event.

[isXander]

That's correct, KeyMappings in vanilla are only used for in-game actions. My oversight.

And yes, it's intentional that controller presses aren't put through Fabric key events, because Controlify does not ever emulate a key press, only inject into KeyMappings.

The proper way to do this would be use the Controlify API and register controller bindings properly, if you are willing? Else, I will try and figure something out but it won't be pretty.

[mysticdrew]

I'll have to look into your API. I generally not super huge in depending on other mods. But, I think full integration for controllers would be nice.

Our Keymapping logic is super old, I need to clean it up and rewrite it to be a bit more modern.