Conversation
46bc9fc to
8b3d2ba
Compare
Also, delete manifest now that we can point to the right `ParticleDA` using the `[sources]` section of the project file. This should make it easier to run benchmarks when updating list of dependencies of `ParticleDA`.
8b3d2ba to
ee8a342
Compare
Member
Author
|
Well, I'm missing why the CI job claims that it can't push the the benchmark results branch, because it very much did push. Anyway, benchmarks are running correctly, and using the right package (i.e. the local one, as intended) without using the manifest at all thanks to the |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, delete manifest now that we can point to the right
ParticleDAusing the[sources]section of the project file. This should make it easier to run benchmarks when updating list of dependencies ofParticleDA.