-
Notifications
You must be signed in to change notification settings - Fork 111
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website broken #210
Comments
Not an issue with Website. My extension broke it. I was using a dark mode extension which seems to conflict with how this website runs. For reference: https://chrome.google.com/webstore/detail/dmghijelimhndkbmpgbldicpogfkceaj |
Oops, I had the |
In my case it was Urban VPN Proxy |
Same issue for me. P.S. Incognito mode is a workaround |
On Firefox, Dashlane and Dark Reader break the page. That being said, it still probably has something to do with this website since it was working fine about a week ago and other websites work fine. |
I would say this is an issue. The page should be less fragile to common Chrome extensions. |
I just pushed an update to the site. Is anyone still getting a busted experience? Do you see any elements warned in the console? |
@tannerlinsley Yeah, the site is still not working for me with dark reader enabled in Brave Browser (with shields down). Disabling it for the site fixes the issue for me. Dark reader modifies the head section of the DOM which I'm guessing is what is triggering the issue. I think the issue is happening here: Line 57 in 16b239f
|
@ChristopherHaws Do you know when those nodes are being added? If I can get a script in before the extension executes, I can keep track of the delta and remove them temporarily while react hydrates, then put them back. |
@tannerlinsley from what I can see, it looks like they are adding a reactive observable which mutates different parts of the DOM at different points. The logic lives here: https://github.com/darkreader/darkreader/blob/main/src/inject/utils/dom.ts |
It looks like you can disable the extension for your site via a meta tag: https://github.com/darkreader/darkreader/blob/main/CONTRIBUTING.md |
I swear Theo Brown mentioned in a recent video that he had to deal with hydration vs plugins a while back. Tanner, he might have some insight. (Not at-mentioning since I don’t know them, personally) |
Update: nope. Still broken. I wonder if Noir behaves differently when the OS is set to auto vs when the OS is set to Dark Mode. That is the only reason I can think of why the site would be down again because of Noir (in the evening, when auto dark mode kicks in on my machine). Not sure why Noir behaves differently from auto dark mode to plain old I-turned-it-on-manually dark mode, but it must. |
For me, an extension called "autoscroll" broke this site. uBlock origin also broke it last week, but I disabled it and the site started working again. I didnt touch autoscroll then. Today the site didnt work and I disabled autoscroll too, and it started working. Strange. |
For me, the extension Dashlane broke this site, disabling it made it work |
Please just revert whatever change caused this. I'm not going to disable my extensions just to see documentation. |
This line of code in the __root.tsx gives me an error when I forked. Removing it removed the error, but I'm not sure the errors are related to the above
|
I'm having the same issue in Firefox Developer Edition. I also tried an incognito window, which should eliminate any extensions as the culprit since none of them are enabled to run in private windows. |
The text was updated successfully, but these errors were encountered: