fix(react-query): move away of uSES #8434
Conversation
|
View your CI Pipeline Execution ↗ for commit 7e7d55c.
☁️ Nx Cloud last updated this comment at |
…/8384 # Conflicts: # packages/react-query/src/__tests__/useQuery.test.tsx
| @@ -54,65 +54,6 @@ describe('useIsFetching', () => { | |||
| await findByText('isFetching: 0') | |||
| }) | |||
|
|
|||
| it('should not update state while rendering', async () => { | |||
There was a problem hiding this comment.
I'm guessing we should just trust React to optimize re-renders? 🤷
This reverts commit dcf16f2. # Conflicts: # packages/react-query/src/useBaseQuery.ts
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore | ||
| global.IS_REACT_ACT_ENVIRONMENT = true |
There was a problem hiding this comment.
followed what Rick suggested here https://discord.com/channels/514829729862516747/1251229763838677052/1318328930658418718
| { | ||
| "editor.defaultFormatter": "esbenp.prettier-vscode", | ||
| "editor.formatOnSave": true | ||
| } |
There was a problem hiding this comment.
Feel free to remove this, but it helps me as a contributor - I have a bunch of settings in trpc https://github.com/trpc/trpc/tree/next/.vscode
| if (defaultedOptions.experimental_prefetchInRender) { | ||
| // Do not notify on updates because of changes in the options because | ||
| // these changes should already be reflected in the optimistic result. | ||
| observer.setOptions(defaultedOptions, { listeners: false }) |
There was a problem hiding this comment.
Setting the options straight away for experimental_prefetchInRender seems to fix it.
I think the issue I had was some race condition...
I still have no reliable reproduction though
Closes #8384 (I think/hope !?!!?)
Refactor
@tanstack/react-queryto not rely onuseSyncExternalStore()as it creates issues in concurrent renderingI think it works!? I added the repro in examples and I also tried to add a test to make it fail