fix: FormApi's deleteField method now updates the store

* Add basic tests for arrays * Ran prettier * Ran prettier * Add new test for bug * Fix bug regarding preserved values even if field is umounted * Run prettier * Update store subscription when removingFields * Fix delete field * Fix delete field * chore: fix linting --------- Co-authored-by: Corbin Crutchley <[email protected]>
TanStack · Nov 5, 2023 · 1a37fab · 1a37fab
1 parent 90bd06f
commit 1a37fab
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/packages/form-core/src/FormApi.ts b/packages/form-core/src/FormApi.ts
@@ -551,11 +551,12 @@ export class FormApi<TFormData, ValidatorType> {
   }
 
   deleteField = <TField extends DeepKeys<TFormData>>(field: TField) => {
-    const newState = { ...this.state }
-    delete newState.values[field as keyof TFormData]
-    delete newState.fieldMeta[field]
-
-    this.store.setState((_) => newState)
+    this.store.setState((prev) => {
+      const newState = { ...prev }
+      delete newState.values[field as keyof TFormData]
+      delete newState.fieldMeta[field]
+      return newState
+    })
   }
 
   pushFieldValue = <TField extends DeepKeys<TFormData>>(

diff --git a/packages/form-core/src/tests/FieldApi.spec.ts b/packages/form-core/src/tests/FieldApi.spec.ts
@@ -611,5 +611,7 @@ describe('field api', () => {
     // Field should have been removed from the form as well
     expect(form.state.values.name).toBeUndefined()
     expect(form.state.fieldMeta.name).toBeUndefined()
+    expect(form.store.state.values.name).toBeUndefined()
+    expect(form.store.state.fieldMeta.name).toBeUndefined()
   })
 })