-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternatives to msrv_speed_ms_per_inch #24
Comments
Sorry for the late replay and thank you for the suggestion. Can I ask about No2 a bit more to make it clear?
I feel, regardless of the orientation, the distance between the current-selected position and the next target point is the same. Or when you are talking about the bigger device, it has bigger items than a smaller device? |
Yes, in my case items had "match_parent" width and so they were bigger when I change orientation to landscape, for example. |
I see. I understand your use case. I will try and see if I can handle that use case and get back to you. |
Hello and thank you for your library, it helped me a lot! However, I found an issue in your implementation.
In fact there are two issues in one:
I'll explain the second issue as it is more important.
If you swipe your recyclerview on a small screen in portrait mode with (for example) msrv_speed_ms_per_inch=50, it will change the page pretty fast. But if you'll try it on a bigger device (on a tablet), it will scroll really slow, because it has a larger surface and it takes more time to reach target point.
Instead, it would be better to declare a constant time for snap helper, that will be equally fast on both devices.
The text was updated successfully, but these errors were encountered: