Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hasChanged always return false #111

Open
Crinchy opened this issue Jan 3, 2025 · 3 comments
Open

hasChanged always return false #111

Crinchy opened this issue Jan 3, 2025 · 3 comments

Comments

@Crinchy
Copy link

Crinchy commented Jan 3, 2025

Hey @TahaSh 🙌

I am currently upgrading to the latest version of swapy and have noticed that the hasChanged property is always returning false, even if the swapped items has been changed. My code needs to run only if the hasChanged is true, this bug is currently preventing my swapping from working.
@TahaSh
Copy link
Owner

TahaSh commented Jan 19, 2025

Hey @Crinchy! Any specific setup to reproduce the issue? It's working on my end—you can check the example from the docs: https://swapy.tahazsh.com/docs/swap-end-event/

@TahaSh
Copy link
Owner

TahaSh commented Jan 19, 2025

ah, the issue happens only for manualSwap. I fixed it in v1.0.5. Thanks for reporting this issue!!

@Crinchy
Copy link
Author

Crinchy commented Jan 19, 2025 •
edited
Loading

@TahaSh perfect brother, thanks for your fix! ❤️
I will test it again and let you know if its fixed on my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TahaSh @Crinchy