Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Node getHasChildNodeSelected not recursive #4155

Open
twojtylak opened this issue Sep 18, 2024 · 0 comments · May be fixed by #4156
Open

[BUG] Node getHasChildNodeSelected not recursive #4155

twojtylak opened this issue Sep 18, 2024 · 0 comments · May be fixed by #4156

Comments

@twojtylak
Copy link
Contributor

Describe the bug
Currently, the GetHasChildNodeSelected function in \ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionBased\Hierarchy\Node only checks whether a direct child is selected. With hierarchical filters, however, it makes sense to check whether any child is selected in this hierarchy branch. E.g. because this should be expanded in the frontend.

To Reproduce
Steps to reproduce the behavior:

  1. Create a hierarchical filter with more than 3 levels
  2. Select 3 level child
  3. {childNode.hasChildNodeSelected} on top level parent of selected child will return false

Expected behavior
GetHasChildNodeSelected should return if any child node is selected

Used versions (please complete the following information):

  • TYPO3 Version: >= 12
@twojtylak twojtylak linked a pull request Sep 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant