Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Refactor VariantsProcessor, ResultSetReconstitutionProcessor and AutoCorrection #4141

Open
Tracked by #3995
dkd-friedrich opened this issue Sep 2, 2024 · 0 comments
Open
Tracked by #3995

[TASK] Refactor VariantsProcessor, ResultSetReconstitutionProcessor and AutoCorrection #4141

dkd-friedrich opened this issue Sep 2, 2024 · 0 comments
Assignees
@bmack @dkd-friedrich @dkd-kaehm

Comments

@dkd-friedrich
Copy link
Member

What should be done in the scope of this task?

Interface ResultSetReconstitutionProcessor is only used VariantsProcessor and ResultSetReconstitutionProcessor, but never checked.

We should:

  • deprecate interface ResultSetReconstitutionProcessor
  • use AfterSearchHasBeenExecutedEvent for processing
    • reimplement existing VariantsProcessor via event listener
    • remplement existing ResultSetReconstitutionProcessor via event listener
    • move autocorrection from SearchResultSetService to an event listener
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmack bmack

@dkd-friedrich dkd-friedrich

@dkd-kaehm dkd-kaehm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bmack @dkd-friedrich @dkd-kaehm