Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Feature flag to skip RecordMonitor and GarbageCollection #4108

Open
kitzberger opened this issue Jul 16, 2024 · 0 comments · May be fixed by #4109
Open

[FEATURE] Feature flag to skip RecordMonitor and GarbageCollection #4108

kitzberger opened this issue Jul 16, 2024 · 0 comments · May be fixed by #4109

Comments

@kitzberger
Copy link
Contributor

kitzberger commented Jul 16, 2024 •
edited
Loading

Problem

Currently the 2 hooks of EXT:solr into DataHandler are fired for all sites, their pages and records. This is time consuming. Especially the RecordMonitor is taking up to 10s to do its thing.

Side note: recursively changing the permissions (owner, group, bit-mask) of a page tree via "Access" module is the mother of all killer operations and often runs into memory allocation problems:

:goberserk: Fatal error: Allowed memory size of 402653184 bytes exhausted

But that seems to be a whole different problem, I believe.

Solution

For sites that don't use solr, it'll be great to have them skip the DataHandler hooks completely.

Target versions

EXT:solr 12.x
@kitzberger kitzberger changed the title [FEATURE] Please describe your feature wish here [FEATURE] Feature flag to skip RecordMonitor and GarbageCollection Jul 16, 2024
@kitzberger kitzberger linked a pull request Jul 16, 2024 that will close this issue
Open
dkd-kaehm pushed a commit to kitzberger/ext-solr that referenced this issue Jul 17, 2024
@kitzberger @dkd-kaehm
[Fetaure] skip DataHandler hooks by site config setting
5d9c2d5 
Currently the 2 hooks of EXT:solr into DataHandler are fired for all sites, their pages and records. This is time consuming. Especially the RecordMonitor is taking up to 10s to do its thing.
Both GarbageCollector and RecordMonitor should skip their processDatamap_afterDatabaseOperations method, 
to avoid unneccessery processing for sites.

Fixes: TYPO3-Solr#4108
dkd-kaehm pushed a commit to kitzberger/ext-solr that referenced this issue Jul 17, 2024
@kitzberger @dkd-kaehm
[Fetaure] skip DataHandler hooks by site config setting
7963665 
Currently the 2 hooks of EXT:solr into DataHandler are fired for all sites, 
their pages and records. This is time consuming. 
Especially the RecordMonitor is taking up to 10s to do its thing.
Both GarbageCollector and RecordMonitor should skip their 
processDatamap_afterDatabaseOperations method, to avoid 
unneccessery processing for sites.

Fixes: TYPO3-Solr#4108
dkd-kaehm pushed a commit to kitzberger/ext-solr that referenced this issue Aug 26, 2024
@kitzberger @dkd-kaehm
[Fetaure] skip DataHandler hooks by site config setting
5c6ad77 
Currently the 2 hooks of EXT:solr into DataHandler are fired for all sites, 
their pages and records. This is time consuming. 
Especially the RecordMonitor is taking up to 10s to do its thing.
Both GarbageCollector and RecordMonitor should skip their 
processDatamap_afterDatabaseOperations method, to avoid 
unneccessery processing for sites.

Fixes: TYPO3-Solr#4108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FEATURE] Add flag to site config to skip DataHandler hooks kitzberger/ext-solr
1 participant
@kitzberger