Remove redundant check and extra tests for elevation in boxshadows

Author: Thomas

__tests__/fixtures/outputs/generator/elevationBoxShadow.js

@@ -4,35 +4,35 @@ module.exports = {
         shadowOffset: {width: 0, height: 1},
         shadowOpacity: 1,
         shadowRadius: 3,
-        elevation: 1.5,
+        elevation: 3,
     },
     shadowMd: {
         shadowColor: '#FFFF00',
         shadowOffset: {width: 0, height: 4},
         shadowOpacity: 1,
         shadowRadius: 6,
-        elevation: 3,
+        elevation: 2,
     },
     shadowLg: {
         shadowColor: '#FFFFFF',
         shadowOffset: {width: 0, height: 10},
         shadowOpacity: 1,
         shadowRadius: 15,
-        elevation: 7.5,
+        elevation: 1,
     },
     shadowXl: {
         shadowColor: '#00FF00',
         shadowOffset: {width: 0, height: 20},
         shadowOpacity: 1,
         shadowRadius: 25,
-        elevation: 12.5,
+        elevation: 20,
     },
     shadow2xl: {
         shadowColor: '#0000FF',
         shadowOffset: {width: 0, height: 25},
         shadowOpacity: 1,
         shadowRadius: 50,
-        elevation: 25,
+        elevation: 5,
     },
     shadowInner: {
         shadowColor: 'rgba(0, 0, 0, 0)',
@@ -46,7 +46,7 @@ module.exports = {
         shadowOffset: {width: 0, height: 0},
         shadowOpacity: 1,
         shadowRadius: 0,
-        elevation: 0,
+        elevation: 7,
     },
     shadowNone: {
         shadowColor: 'rgba(0, 0, 0, 0)',

__tests__/generator.test.js

@@ -248,3 +248,30 @@ test('shadows with hex colors', () => {
     expect(resultBox).toEqual(require('./fixtures/outputs/generator/hexColorBoxShadow'));
     expect(resultText).toEqual(require('./fixtures/outputs/generator/hexColorTextShadow'));
 });
+
+test('shadows with custom elevation', () => {
+    const resultBox = generator.generateShadows('shadow', 'shadow', {
+        default: '0 1px 3px 0 #FF0000, 3',
+        md: '0 4px 6px -1px #FFFF00, 2',
+        lg: '0 10px 15px -3px #FFFFFF,1',
+        xl: '0 20px 25px -5px #00FF00,20',
+        '2xl': '0 25px 50px -12px #0000FF, 5',
+        inner: 'inset 0 2px 4px 0 #F0000F,6',
+        outline: '0 0 0 3px #000FF0,7',
+        none: 'none',
+    });
+
+    const resultText = generator.generateShadows('text-shadow', 'textShadow', {
+        default: '0 1px 3px 0 #FF0000, 3',
+        md: '0 4px 6px -1px #FFFF00, 2',
+        lg: '0 10px 15px -3px #FFFFFF,1',
+        xl: '0 20px 25px -5px #00FF00,20',
+        '2xl': '0 25px 50px -12px #0000FF, 5',
+        inner: 'inset 0 2px 4px 0 #F0000F,6',
+        outline: '0 0 0 3px #000FF0,7',
+        none: 'none',
+    });
+
+    expect(resultBox).toEqual(require('./fixtures/outputs/generator/elevationBoxShadow'));
+    expect(resultText).toEqual(require('./fixtures/outputs/generator/elevationTextShadow'));
+});

util/generator.js

@@ -113,10 +113,7 @@ export default {
             currentColorKeys;
 
         for (color in colors) {
-
-            if (colors.hasOwnProperty(color)) {
-                colorName = color;
-            }
+            colorName = color;
 
             currentColor = colors[colorName];