-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graph_from_smiles() missing #85
Comments
|
Thank you very much for pointing to the commit where this was removed. Actually did not remember that it was one of the parts based on RDKit that we dediced to kick out due to problems with metal complex handling. In the meantime, I also figured out how to access Interestingly,
|
Still, seems to be only these few lines from the above code section:
Even if they "inherit" the issues of the RDKit with metals I'd possibly argue to have a function for that for people to use at own risk? |
This is one of the things I forgot in the recent discussion - would be nice to also have SMILES as input for TUCAN, which can be done by above code fragment using RDkit SMILES_to_v3000_molfile function |
I'm curious - aside from the issue metal complexes, why was RDKit removed? |
Good question - don't really remember the answer anymore since this modification was done more than 6 months ago, but maybe Jan can give feedback. My best guess is that it was the last dependency on RDKit that we had in the TUCAN and on one hand, we did not need it for anything else anymore, so would simplify dependencies, and then of course "the issue with the metal complexes" is not a minor one. We had a long developers' meeting today with some new people joining and will further formalize and harmonzie the different input variants in the upcoming months. Also plan for PubChem, ChEMBL and CSD interfaces as well as ORCA and Gaussian computational chemistry file formats as input, plus a lot of other interesting stuff (-:= On that occassion - you are really missed on Twitter, just realized today that there were new posts in your blog ... |
In tests_chembl.ipynb the function
graph_from_smiles()
is used to convert a SMILES string to a graph, which is useful when processing ChEMBL and PubChem structures.This was once included in
tucan.io
according tofrom tucan.io import graph_from_smiles
However, it seems like this function got lost somewhere on the way and is not included in
molfile_reader.py
anymore (although admittedly it also does not make much sense under this name).I would strongly like to have it back again to
tucan.io
I can also provide a
graph_from_csd
routine (although it requires a local installation of the CSD database) and currently work on agraph_from_pubchem
function, since one can also read the atoms and bonds directly (as with the CSD), therefore making the detour via the SMILES string unnecessary, see:PubChemPy Dictionary representation
The text was updated successfully, but these errors were encountered: