-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web-based demo version #67
Comments
My investigations so far: @rapodaca has written several blog articles and GH-repos about porting the InChI C-library to JavaScript and WebAssembly:
Thus, I'll try to convert TUCAN to C as a next step (maybe with Cython) ... |
A possibly less suitable option would be to run TUCAN on a server and expose the interface through a browser. See also Running InChI Anywhere with WebAssembly for an overview of efforts around InChI and Wasm. |
Frank - what is still missing for the web demo? Checked the last version with Ketcher as editor and it looked pretty much complete to me ... |
The feedback from our project team was quite positive, so I just moved the demo website to https://tucan-nest.github.io by renaming the repository. This covers the following use-cases:
Other use-cases that will be added as soon as TUCAN supports it:
|
So can we promote this in the public now or you would like to wait for some more time for feedback? |
Yes, it can be promoted. |
A few words on the technical background: igraph wheel: TUCAN wheel: Glue code: Chemical structure editor:
Implicit hydrogens: |
BTW, just the repository or also the demo website? |
Do you mean what should be promoted? I think just the URL https://tucan-nest.github.io. People interested in the website's source code will be clever enough to find the repository because GitHub pages always follows the same pattern. |
Ok, it was not clear to me that the running demo is also included there. Then I will start to promote the link that you included above on social media later today. |
@flange-ipb, can we close this issue? |
Not yet. The features related to TUCAN-to-Molfile conversion are still missing and we may need some discussions on the web design. |
Just found another problem - in some cases the coordinate generation results in very small (< 10e-7) values which makes little sense. Therefore, I would like to suggest to set coordinate values to zero if initial values is below a certain threshold, best < 0.0001 since most experimental and theoretical methods cannot provide more accurate values. |
Thanks for pointing this out. Indeed, I incorrectly use the format
It adds trailing zeros (you can also see this in Molfiles exported by ChemDraw). The "negative zero" is a bit flawed. |
I think that does not matter that much. |
The spec is silent on the issue of number format for coordinates. It doesn't follow the "Fortran format" convention for decimal values in the header. Still, no example in any documentation I've founded uses exponential notation. So the V3K library I'm working on Trey, will report an error if given exponential notation. Other tools may do the same. |
I'm not that familiar with the code that Frank Lange (flange-ipb) has contributed but the Might come from ketcher editor? Still, even if it is just for more pleasant reading by humans, I'd prefer not to have the exponential notation. Normal high-quality low-temperature X-ray diffraction gives coordinates to three relevant digits behind the comma. DFT will provide more digits but since they cannot be calibrated against experimental data of that accuracy are more or less useless. The |
No, in case It's interesting to see how others implemented coordinate serialization: |
Thank you very much for checking how rdkit and CDK do this. Could you please also link to the part of the TUCAN code where the Kamada-Kawai coordinates are collected and then passed on to molfile generation? In |
That's not yet merged. See my pull request. |
That's too many changes - I better leave it to @JanCBrammer to approve and merge ;-) But now I got it:
Really just directly coming from the NetworkX Kamada-Kawai routine. In case somebody is interested in the original paper, it is here: https://dx.doi.org/10.1016/0020-0190(89)90102-6 T. Kamada, S. Kawai, An algorithm for drawing general undirected graphs, Information Processing Letters, 1989, 31, 7-15 |
In the web demo, when using
Still, it would be possible to convert this to a graph and then generate a canonical TUCAN from it for further processing. Is it intended behaviour here to terminate with an error message or shouldn't there at least also be a function |
Since this functionality is already around - do you think it would be useful to have a separate "generic TUCAN to canonical TUCAN" option, where you can type in any TUCAN and then get the canonical one out? Such a string-to-string conversion is currently missing ... |
Having a website (e.g., SPA) for demo purposes would increase accessibility a lot. Currently, the accessibility of TUCAN is too limited, since the package needs to be installed in a local Python environment.
The text was updated successfully, but these errors were encountered: