feat: prevent default vars copy #484
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a work in progress. I still need to merge tdp_vars with all tdp_vars_default to be able to validate the variables' schema. |
PaulFarault
force-pushed
the
320-do-not-copy-tdp_vars_default-in-tdp_vars
branch
from
c305796 to
4919629
Compare
rpignolet
reviewed
Oct 31, 2023
PaulFarault
force-pushed
the
320-do-not-copy-tdp_vars_default-in-tdp_vars
branch
3 times, most recently
from
9df8f5a to
9c82f03
Compare
|
Force pushed after rebase on master |
|
We should base the repository creation on the default variables instead of the collections. This ensure that the service is expecting some variables (as services can be artificially added by users, without requiring any vars). |
PaulFarault
force-pushed
the
320-do-not-copy-tdp_vars_default-in-tdp_vars
branch
from
9c82f03 to
03cf6fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes
Fixes #320
Additional comments
Agreements