Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling in room stats and attendance #1600

Merged
merged 8 commits into from
Jan 14, 2025
Merged

Improve error handling in room stats and attendance #1600

merged 8 commits into from
Jan 14, 2025

Conversation

SamuelWei
Copy link
Collaborator

@SamuelWei SamuelWei commented Nov 21, 2024 •
edited
Loading

Fixes #1535

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.): Error Handling
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Improve error handling in room statistics dialog
  • Improve error handling in room attendance dialog
  • Add happo.io for visual testing

@SamuelWei SamuelWei linked an issue Nov 21, 2024 that may be closed by this pull request
Improve error handling in room history components #1535
Closed
@codecov Codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.14%. Comparing base (ae732b9) to head (5c55c92).
Report is 3 commits behind head on develop.

Additional details and impacted files 
@@              Coverage Diff              @@
##             develop    #1600      +/-   ##
=============================================
+ Coverage      81.09%   81.14%   +0.05%     
  Complexity      1355     1355              
=============================================
  Files            362      362              
  Lines           9277     9304      +27     
  Branches         860      867       +7     
=============================================
+ Hits            7523     7550      +27     
  Misses          1754     1754

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress Cypress
Copy link

cypress bot commented Nov 21, 2024 •
edited
Loading

PILOS    Run #1647

Run Properties:  status check passed Passed #1647  •  git commit 13de37bceb: Improve error handling in room stats and attendance (#1600)
Project PILOS
Branch Review develop
Run status status check passed Passed #1647
Run duration 04m 50s
Commit git commit 13de37bceb: Improve error handling in room stats and attendance (#1600)
Committer Samuel Weirich
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 238
View all changes introduced in this branch ↗︎

@SamuelWei SamuelWei force-pushed the 1535-improve-error-handling-in-room-history-components branch 2 times, most recently from 36d3017 to 1d56b83 Compare December 20, 2024 14:24
@SamuelWei SamuelWei force-pushed the 1535-improve-error-handling-in-room-history-components branch from 98e361e to 4f41f89 Compare January 13, 2025 15:31
@SamuelWei SamuelWei force-pushed the 1535-improve-error-handling-in-room-history-components branch from 530134f to 9f63b6d Compare January 13, 2025 17:50
@SamuelWei SamuelWei marked this pull request as ready for review January 14, 2025 14:41
@SamuelWei SamuelWei added this to the v4.3 milestone Jan 14, 2025
@SamuelWei SamuelWei added the UI User Interface label Jan 14, 2025
@SamuelWei SamuelWei merged commit 13de37b into develop Jan 14, 2025
19 checks passed
@SamuelWei SamuelWei deleted the 1535-improve-error-handling-in-room-history-components branch March 25, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
UI User Interface
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.

Improve error handling in room history components
1 participant
@SamuelWei