Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing check for traits in Trait submission wizard. #746

Open
wjurkowski opened this issue Sep 27, 2017 · 2 comments
Open

Confusing check for traits in Trait submission wizard. #746

wjurkowski opened this issue Sep 27, 2017 · 2 comments

Comments

@wjurkowski
Copy link
Collaborator

A user was searching for 'biochemical trait' using the 'Trait descriptor list' field and got no results. Then they attempted to create it from scratch. When writing in the 'Trait' field to define the new trait descriptor, 'biochemical trait' appeared as already present in the database.
I can understand some technical reasons for this, but I think it's clear that it's counter-intuitive and it suggests some bad behaviour in the search field of the 'Trait descriptor list'.
Could search for existing traits in the database rather than in the dictionary solve this problem. In addition I suggest to minor GUI changes to avoid confusion

  • Change Trait to New Trait Name
  • Add text: "Please contact us if you propose new traits that are not present in the trait ontology"
@Nuanda
Copy link

Nuanda commented Sep 28, 2017

There is no "technical" reason behind it. It is actually the way we have (together with you and Annemarie) designed it. Trait is just a name of a trait, a dictionary field. While Trait Descriptor is the entire description of the way a trait is measured in a trial. The name might be misleading but we have it from the CropStore schema, so we've kept it.

In order to be able to submit a scoring, a Trait Descriptor has to be defined (there are certain fields we require from a user regarding how she measures it) - that's why we have this two-step creator.

@wjurkowski
Copy link
Collaborator Author

I know, I wasn't suspecting any issue behind it, just marking that we need to perhaps add some clarification in the text below boxes and in the documentation pdf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants