Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: share link url updated #1127

Conversation

ChiragPansuriya-iView
Copy link
Collaborator

No description provided.

Copy link

netlify bot commented Mar 20, 2024

Deploy Preview for teritori-dapp ready!

Name Link
🔨 Latest commit f403e88
🔍 Latest deploy log https://app.netlify.com/sites/teritori-dapp/deploys/6606898163a8cc0008c887b0
😎 Deploy Preview https://deploy-preview-1127--teritori-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 20, 2024

Deploy Preview for testitori ready!

Name Link
🔨 Latest commit f403e88
🔍 Latest deploy log https://app.netlify.com/sites/testitori/deploys/66068981ae4d0e0008a3f0f7
😎 Deploy Preview https://deploy-preview-1127--testitori.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

omniwired
omniwired previously approved these changes Mar 20, 2024
WaDadidou
WaDadidou previously approved these changes Mar 20, 2024
Copy link
Collaborator

@n0izn0iz n0izn0iz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like I said, there is a medium refactor needed, ShareButton should take the network-prefixed-postid as prop, using the selected network is not reliable, and will break when we will have cross-chain feed, also the #Teritori anchor is very weird

@ChiragPansuriya-iView ChiragPansuriya-iView force-pushed the 1120-share-post-link-uses-raw-id-instead-of-network-object-id branch from 14cdf5d to 8040655 Compare March 22, 2024 05:08
@ChiragPansuriya-iView ChiragPansuriya-iView marked this pull request as ready for review March 22, 2024 10:22
Copy link
Collaborator

@n0izn0iz n0izn0iz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChiragPansuriya-iView ChiragPansuriya-iView force-pushed the 1120-share-post-link-uses-raw-id-instead-of-network-object-id branch from c9b6e83 to f403e88 Compare March 29, 2024 09:27
@n0izn0iz
Copy link
Collaborator

Closing in favor of #1161

@n0izn0iz n0izn0iz closed this Mar 29, 2024
@n0izn0iz n0izn0iz deleted the 1120-share-post-link-uses-raw-id-instead-of-network-object-id branch March 29, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

share post link uses raw id instead of network object id
4 participants