Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet): TX detail screen #1116

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(wallet): TX detail screen #1116

wants to merge 3 commits into from

Conversation

omniwired
Copy link
Collaborator

No description provided.

@omniwired omniwired linked an issue Mar 19, 2024 that may be closed by this pull request
Wallet: See into transaction history detail not implemented #1066
Open
@netlify Netlify
Copy link

netlify bot commented Mar 19, 2024 •
edited
Loading

✅ Deploy Preview for testitori ready!

Name Link
🔨 Latest commit 180d260
🔍 Latest deploy log https://app.netlify.com/sites/testitori/deploys/660b7127b501890008486977
😎 Deploy Preview https://deploy-preview-1116--testitori.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Mar 19, 2024 •
edited
Loading

✅ Deploy Preview for teritori-dapp ready!

Name Link
🔨 Latest commit 180d260
🔍 Latest deploy log https://app.netlify.com/sites/teritori-dapp/deploys/660b7127e30a880008fa6fb8
😎 Deploy Preview https://deploy-preview-1116--teritori-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

n0izn0iz
n0izn0iz requested changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@n0izn0iz n0izn0iz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • the heuristics are not okay (eg type.includes("send"))
  • we already have transaction details and preview components, check multisig transactions

@omniwired omniwired self-assigned this Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n0izn0iz n0izn0iz n0izn0iz requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@omniwired omniwired

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wallet: See into transaction history detail not implemented
2 participants
@omniwired @n0izn0iz