Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make substrings of the name in dropdown selections of recipient to be searchable #13054

Open
FergusMok opened this issue Apr 18, 2024 · 27 comments
Labels
c.Feature User-facing feature; can be new feature or enhancement to existing feature good first issue Easy; restricted for first-time contributors

Comments

@FergusMok
Copy link
Contributor

Description of feature/enhancement
image

Context
When selecting students from a drop-down, there may be many students. If I know the recipient in advance, I would like to quickly type the name from the options and get the selection.

Problem
Currently, the code-base supports for searching only if I type the start of the name.
The problem is when I'm trying to search for a surname, or for example in the screenshot, their first names are prefixed with the section / team names. This makes the search essentially useless.

Being able to search with some sort of substring of the name (all possible substrings, or substrings separated by spaces) will help improve the submission user experience.

@FergusMok FergusMok added good first issue Easy; restricted for first-time contributors c.Feature User-facing feature; can be new feature or enhancement to existing feature labels Apr 18, 2024
Copy link

Good First Issue - Notes for Contributors
This issue is for first-time contributors only. If you are new to TEAMMATES, feel free to submit a PR for this issue.

Please note that we allow only one good first issue per contributor. If you have already made a prior contribution to TEAMMATES, you may wish to take a look at issues with the help wanted tag instead.

We do not assign issues to contributors. If you would like to pick up this issue, do post a comment below to express your interest and check if there is anyone else who is already working on the issue. We will do our best to reply and give you the go-ahead, but if we don't, feel free to submit a PR as long as there is no one else working on it.

To get started, do read through our contributing guidelines carefully, and set up a development environment on your local machine before making a PR.

If you need any clarifications on our developer guide, or are facing issues that are not found in our troubleshooting guide, please post a message in our discussion forum.

@malimsZen
Copy link

Can I take a look at this issue?

@FergusMok
Copy link
Contributor Author

@malimsZen Yes, nobody has claimed the issue, feel free to open a PR!

@glizondo
Copy link

Hello, @malimsZen please, let me know if you end up not working on this issue, I would like to work on it if that is ok

@Akshay1018
Copy link

Hi @FergusMok , can you assign this issue to me? I can solve this problem by this weekend and keep you updated.

@FergusMok
Copy link
Contributor Author

@Akshay1018 Let's give @malimsZen some time to work on it as he claimed it first

@Akshay1018
Copy link

Ok @FergusMok , let me now if the issue if not taken up by @malimsZen So, that I can take it up.

@malimsZen
Copy link

Hi @Akshay1018 , feel free to take up the task. After evaluating the issue I saw I'm not a perfect fit to offer a solution to the issue.

@Akshay1018
Copy link

Hi @FergusMok, please assign this task to me. Thanks.

@FergusMok
Copy link
Contributor Author

@Akshay1018 Please feel free to go ahead and open a PR for the issue

@Akshay1018
Copy link

Thanks @FergusMok

@shivam-102
Copy link

@FergusMok Can I take up the task?

@FergusMok
Copy link
Contributor Author

@Akshay1018 Will you still be working on the task? If not, another person has opened a PR for it, and we'll proceed to review it.

@shuklaom
Copy link

shuklaom commented May 3, 2024

Hello, I am new to this repository and I have a question.

Instead of searching for the surname of the recipient, would it be possible to search for an associated email address or a unique identifying number that is linked to the recipient? This approach could help eliminate the possibility of confusion in situations where there may be two people with the same name on the same team. It would be difficult to determine which recipient is which student by simply searching for their name in such cases.

@AtulYadavCodes
Copy link

can i take this issue

@KenaiiDev
Copy link

Hi. Can I take this issue or are there someone working on it?

@DizzyG123
Copy link

Anyone taking a look at the issue at the moment? I would like to work on this.

@mingyuanc
Copy link
Contributor

@DizzyG123 sure!

@namrataajmeri16
Copy link

namrataajmeri16 commented Aug 7, 2024

Hi @FergusMok . Is anyone working on this issue? I can take up if no one is working rightnow.

@domoberzin
Copy link
Contributor

hi @namrataajmeri16 , there is an existing PR open for this in #13097 , and there are also others above who are keen to take on the issue. Let's wait for a couple more days to see if there's any updates on the existing PR. Meanwhile you can look at other issues to take up

@Nkovaturient
Copy link

Hello, I am new to this repository and I have a question.

Instead of searching for the surname of the recipient, would it be possible to search for an associated email address or a unique identifying number that is linked to the recipient? This approach could help eliminate the possibility of confusion in situations where there may be two people with the same name on the same team. It would be difficult to determine which recipient is which student by simply searching for their name in such cases.

Agree! Good suggestion. tryna work on it!

@Abirami04M
Copy link

Hey, is the issue solved? Can I work on it if it's not done yet?

@ProgrammerKJ
Copy link

Same question here if this is not solved, I would love to solve it!

@Harshitkant21
Copy link

Hi, can i take the issue or someone working on it?

@Kunal-Awasthi02
Copy link

Hello Sir I have an suggestion
just assign a enrollment id as a primary key to each student and instead of searching using name
try to search using enrolment id.

@henriquepaes1
Copy link

Hello! Considering that it's been one month since the last update, and the previous PR was closed due to inactivity, I'll work on this issue.
I would appreciate to know if there's anything I need to know other than what the development guides specify.

@henriquepaes1
Copy link

I was able to set up the development environment and get the application running locally. However, the screenshot shows version V9-0-0-b4 in the bottom left corner. When I run locally, I can only get v8-0-0, that does not change when I manually change the version entry in the build.properties file. As a result, I haven't been able to reproduce the issue scenario because there isn't a dropdown to select a student. Instead, there are several inputs for all the students in the group. Can anyone guide me on how to reproduce this scenario?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Feature User-facing feature; can be new feature or enhancement to existing feature good first issue Easy; restricted for first-time contributors
Projects
None yet