Instructor extending individual deadlines: table doesn't sort by team

[damithc]

v8.29, production

Context: an instructor is in the page that is for extending deadlines.

Problem: when trying to sort by the Team column, the row order stays the same i.e., nothing happens when the up/down icons are clicked. But no such issue with the other columns of the table.

[MaharshiPedu]

Hi @damithc, I could not reproduce this issue. The table does get sorted by Team column.

[damithc]

@MaharshiPedu the case I looked at had a few ongoing extensions already. Perhaps that is the trigger for this bug. Can you try that too?

[MaharshiPedu]

@damithc I tried what you suggested. In spite of giving multiple extensions, the order of sorting of Team column did change by using the arrows beside the column heading.

However, I found that the sorting order is wrong. In ascending order, the order is incorrect. One Team 3 row appears between other Team 2 rows. Have a look at the gif below to get a clear understanding:

[damithc]

@MaharshiPedu Also note that the bug I reported is in the production version which may be a number of commits behind the master branch. So, the behavior you see may be different from the one I reported.

@cedricongjh is this behavior potentially affected by recent PRs that we merged? I remember there was a major PR that was related to table sorting.

[cedricongjh]

yes there was this PR: #12556 that was merged in since the last release, hence the difference in behaviour, it could be worth looking into why the team sort (and the other sorts as well) has an issue when sorted by ascending as @MaharshiPedu pointed out

[rameshmoorjani]

Hello @damithc - I am beginner in open source contribution. Can I participate and work on this issue?

[cedricongjh]

hey @rameshmoorjani, feel free to look into this and open a PR

[Ruimeng-Ye]

Hi @damithc , I am a beginner and also interested in this issue, would you mind me working on this issue and trying to fix it?

[wanqiqiu]

hi, @cedricongjh can I work on this issue to have a try? Thank you!
(uid: u7503408 for reference.)

[cedricongjh]

hi @Ruimeng-Ye and @wanqiqiu, since @rameshmoorjani has expressed interest in this issue, let's give him time to work on it, you're welcome to look into other issues to contribute to!

@rameshmoorjani do let us know if you're still working on it, thank you!

[rameshmoorjani]

@cedricongjh - yes I am working on it, having some issue with setup in local due to ng-in-viewport and Agular version mismatch. I will update asap.

[github-actions]

Good First Issue - Notes for Contributors
This issue is for first-time contributors only. If you are new to TEAMMATES, feel free to submit a PR for this issue.

Please note that we allow only one good first issue per contributor. If you have already made a prior contribution to TEAMMATES, you may wish to take a look at issues with the help wanted tag instead.

We do not assign issues to contributors. If you would like to pick up this issue, do post a comment below to express your interest and check if there is anyone else who is already working on the issue. We will do our best to reply and give you the go-ahead, but if we don't, feel free to submit a PR as long as there is no one else working on it.

To get started, do read through our contributing guidelines carefully, and set up a development environment on your local machine before making a PR.

If you need any clarifications on our developer guide, or are facing issues that are not found in our troubleshooting guide, please post a message in our discussion forum.

[emanuelconte]

Hi @damithc . Can I work on this issue ?

I'm new to open source projects and would like to give this a try.

[cedricongjh]

hi @emanuelconte, feel free to submit a PR!

[azharmd1]

I looked into the code base. I would like to work on this issue. Please assign me!

[WesleyJammer]

hey @damithc, i see this project is still open. So is it possible for me to work on this? i am getting into opensource trough my study and this looks interessting.

[VeldiBharath]

is this issue still open? I would like to contribute !

[dishenggg]

Hi @VeldiBharath, yes feel free to submit a PR!