Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors and Warnings in GitHub Actions Annotations (macos-latest) #985

Open
NimaSarajpoor opened this issue Jun 8, 2024 · 3 comments
Open
Labels
question Further information is requested

Comments

@NimaSarajpoor
Copy link
Collaborator

Even when tests are fully passing, I can see some errors and warnings in the "Annotations" section of Actions.

In unit testing, for macos-latest, python 3.8, I can see the following messages:

[notice] A new release of pip is available: 21.1.1 -> 24.0
[notice] To update, run: python3.8 -m pip install --upgrade pip

I can also see some warning regarding code coverage with "macos-latest":

Codecov: Failed to properly create commit: The process '/Users/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
@NimaSarajpoor NimaSarajpoor changed the title Some errors and warnings in GitHub Actions (macos-latest) Errors and Warnings in GitHub Actions Annotations (macos-latest) Jun 8, 2024
@seanlaw
Copy link
Contributor

seanlaw commented Jun 8, 2024

@NimaSarajpoor I'm not too concerned with either of these warnings/errors

Sure, we could add an extra run to the workflow to update pip. That's fine.

As for the codecov, with tests passing and other other non-macos platforms being able to upload their results, I'm okay with it. From what I've researched, codecov has some kinks that they are still trying to iron out. I'm gonna wait for other people to figure it out first and then we can update it when uploading fails for all platforms.

@seanlaw seanlaw added the question Further information is requested label Jun 8, 2024
@seanlaw
Copy link
Contributor

seanlaw commented Oct 14, 2024

@NimaSarajpoor following up on this, it looks like the pip notice is coming due to the fact that Python 3.8 has already reached end-of-life:

https://devguide.python.org/versions/

So, the runner image actually has an issue with Python 3.8. We should bump the minimum Python version (see #1036).

@seanlaw
Copy link
Contributor

seanlaw commented Oct 14, 2024

This has been resolved by bumping the min python version

see https://github.com/TDAmeritrade/stumpy/actions/runs/11319373201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants