Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have stopSync() stop an active ongoing sync instead of waiting for it to complete. #890

Open
LiranCohen opened this issue Sep 5, 2024 · 0 comments
Open

Have stopSync() stop an active ongoing sync instead of waiting for it to complete. #890

LiranCohen opened this issue Sep 5, 2024 · 0 comments

Comments

@LiranCohen
Copy link
Member

Currently stopSync() waits for an ongoing active sync to complete before clearing the interval.

Implement a signal so that the actual sync operation can gracefully wind down.
LiranCohen added a commit that referenced this issue Sep 6, 2024
@LiranCohen
Modify stopSync to block if sync is currently active (#889)
e578e20 
- Add a missing changset for #887:

`stopSync` now blocks if a current sync is in progress before clearing the interval. An optional timeout can be defined, the default is 2 seconds. After this timeout it will throw.

TestHarness has been updated to stop sync before clearing storage, previously this caused an issue where an ongoing sync would attempt to sign messages for DID that no longer had keys after clearing storage.

#890 has been created to better address this by creating a signal to gracefully stop sync immediately.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LiranCohen