-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly export types not referenced by exported types #822
Explicitly export types not referenced by exported types #822
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #822 +/- ##
=======================================
Coverage 98.99% 99.00%
=======================================
Files 74 74
Lines 11499 11505 +6
Branches 1673 1673
=======================================
+ Hits 11384 11390 +6
Misses 109 109
Partials 6 6 ☔ View full report in Codecov by Sentry. |
This is awesome @aniketh-varma!! Is it possible for you to add the check in |
Hey @thehenrytsai, I do see that the other warnings are still there. This PR addresses only the following warnings-
Should I go ahead and a check for only these warnings? |
Hi @thehenrytsai, do you have any suggestions for the comment above? |
Hey @aniketh-varma! I looked at the remaining warnings and maybe those are better suited for a separate PR. I'll approve this one so that we can get it merged in. |
Hi @thehenrytsai @taniashiba @LiranCohen, please assign the points label to this PR. Can this be considered as |
We're on it, @aniketh-varma ! |
Added medium points for you @aniketh-varma ! |
Fixes #686