Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly export types not referenced by exported types #822

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

aniketh-varma
Copy link
Contributor

Fixes #686

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.00%. Comparing base (0a043f2) to head (7f32845).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #822   +/-   ##
=======================================
  Coverage   98.99%   99.00%           
=======================================
  Files          74       74           
  Lines       11499    11505    +6     
  Branches     1673     1673           
=======================================
+ Hits        11384    11390    +6     
  Misses        109      109           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehenrytsai
Copy link
Member

This is awesome @aniketh-varma!! Is it possible for you to add the check in integrity-check.yml to make sure the job fails if new warnings are introduced going forward (assuming there were no other warnings needing fixing), so that your work is not in vain again.

@aniketh-varma
Copy link
Contributor Author

Hey @thehenrytsai, I do see that the other warnings are still there. This PR addresses only the following warnings-

[warning]... defined in... but not included in the documentation

Should I go ahead and a check for only these warnings?

@angiejones angiejones added the hacktoberfest For the hacking month of October label Oct 16, 2024
@aniketh-varma
Copy link
Contributor Author

Hi @thehenrytsai, do you have any suggestions for the comment above?

@LiranCohen
Copy link
Member

Hey @aniketh-varma! I looked at the remaining warnings and maybe those are better suited for a separate PR. I'll approve this one so that we can get it merged in.

@LiranCohen LiranCohen merged commit 04216e4 into TBD54566975:main Oct 16, 2024
4 checks passed
@aniketh-varma
Copy link
Contributor Author

Hi @thehenrytsai @taniashiba @LiranCohen, please assign the points label to this PR. Can this be considered as Medium? :)

@taniashiba
Copy link
Contributor

We're on it, @aniketh-varma !

@blackgirlbytes
Copy link
Contributor

Added medium points for you @aniketh-varma !

@taniashiba taniashiba added the hacktoberfest-accepted Accepted PRs for the hacking month of October label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest For the hacking month of October hacktoberfest-accepted Accepted PRs for the hacking month of October medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export all types that are referenced by all exported types
7 participants