reset the submission judge if the submission is set to new, no matter what it was previously (#2040)

Masterjun3 · web-flow · commit 307eeea78473 · 2024-11-18T13:08:10.000-06:00
diff --git a/TASVideos.Data/Helpers/SubmissionHelper.cs b/TASVideos.Data/Helpers/SubmissionHelper.cs
@@ -66,9 +66,9 @@ public static bool JudgeIsClaiming(SubmissionStatus oldS, SubmissionStatus newS)
 		return oldS != SubmissionStatus.JudgingUnderWay && newS == SubmissionStatus.JudgingUnderWay;
 	}
 
-	public static bool JudgeIsUnclaiming(SubmissionStatus oldS, SubmissionStatus newS)
+	public static bool JudgeIsUnclaiming(SubmissionStatus newS)
 	{
-		return oldS == SubmissionStatus.JudgingUnderWay && newS == SubmissionStatus.New;
+		return newS == SubmissionStatus.New;
 	}
 
 	public static bool PublisherIsClaiming(SubmissionStatus oldS, SubmissionStatus newS)
diff --git a/TASVideos/Pages/Submissions/Edit.cshtml.cs b/TASVideos/Pages/Submissions/Edit.cshtml.cs
@@ -231,7 +231,7 @@ public async Task<IActionResult> OnPost()
 		{
 			submission.Judge = await db.Users.SingleAsync(u => u.UserName == userName);
 		}
-		else if (SubmissionHelper.JudgeIsUnclaiming(submission.Status, Submission.Status))
+		else if (SubmissionHelper.JudgeIsUnclaiming(Submission.Status))
 		{
 			submission.Judge = null;
 		}

Original file line number	Diff line number	Diff line change
`@@ -66,9 +66,9 @@ public static bool JudgeIsClaiming(SubmissionStatus oldS, SubmissionStatus newS)`
`66`	`66`	`return oldS != SubmissionStatus.JudgingUnderWay && newS == SubmissionStatus.JudgingUnderWay;`
`67`	`67`	`}`
`68`	`68`
`69`		`- public static bool JudgeIsUnclaiming(SubmissionStatus oldS, SubmissionStatus newS)`
	`69`	`+ public static bool JudgeIsUnclaiming(SubmissionStatus newS)`
`70`	`70`	`{`
`71`		`- return oldS == SubmissionStatus.JudgingUnderWay && newS == SubmissionStatus.New;`
	`71`	`+ return newS == SubmissionStatus.New;`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`public static bool PublisherIsClaiming(SubmissionStatus oldS, SubmissionStatus newS)`
Original file line number	Diff line number	Diff line change
`@@ -231,7 +231,7 @@ public async Task<IActionResult> OnPost()`
`231`	`231`	`{`
`232`	`232`	`submission.Judge = await db.Users.SingleAsync(u => u.UserName == userName);`
`233`	`233`	`}`
`234`		`- else if (SubmissionHelper.JudgeIsUnclaiming(submission.Status, Submission.Status))`
	`234`	`+ else if (SubmissionHelper.JudgeIsUnclaiming(Submission.Status))`
`235`	`235`	`{`
`236`	`236`	`submission.Judge = null;`
`237`	`237`	`}`