Lua no global sharing

[SuuperW]

This PR builds on another PR (#3775). (So don't merge this until/unless that one is merged/approved.)

This PR fixes issue #3036. I'm not certain if this is actual desired behavior, since that issue was marked as wontfix but a stated reason for that was "fixing this within the current system would suck". So it's unclear if a fix is wanted, or wasn't done for other reasons.

[YoshiRulz]

The fact that globals are shared isn't great, but we'd want to have a replacement merged and field-tested before disabling this.

[SuuperW]

I did a force-push. The only change compared to previous commmit is in NamedLuaFunction.DetachFromScript.

The fact that globals are shared isn't great, but we'd want to have a replacement merged and field-tested before disabling this.

Do you mean that sharing globals should be an option available to the user? so that we can also keep the old behavior until this has been field-tested

[CasualPokePlayer]

I don't like this. Especially with running simple commands in the Lua Console, as now it can no longer access global variables in scripts (something I've used before as a way to toggle options on/off or just call manually call functions within the script). Scripts sharing globals as is is just a feature. At most we could just have an option to reset Lua state (without the user needing to close/re-open the console), and perhaps a way to open a script with a new lua state (but this not being the default). This PR as-is I will revert if merged.

[SuuperW]

I don't like this. Especially with running simple commands in the Lua Console, as now it can no longer access global variables in scripts (something I've used before as a way to toggle options on/off or just call manually call functions within the script).

I pushed a new commit which may suit your use case. You can now toggle options again if the script is currently highlighted. Please let me know if this is a good solution.

At most we could just have an option to reset Lua state (without the user needing to close/re-open the console)

I don't see how this would solve any issues. Two incompatible scripts would still be incompatible.

perhaps a way to open a script with a new lua state (but this not being the default).

I think making it a setting for the user to choose would make sense. Defaulting to preserve old behavior also makes sense.

[CasualPokePlayer]

I don't see how this would solve any issues.

One of the issue of everything sharing globals means if a script has trashed globals you can't restore it by loading up a new script nor reloading the offending script (probably after the user modifies it), you need to close the lua console and re-open it.

I pushed a new commit which may suit your use case. You can now toggle options again if the script is currently highlighted. Please let me know if this is a good solution.

This isn't a good idea, this behavior wouldn't be obvious to any user, and as you've made it it wouldn't work at all if multiple scripts are highlighted? (or it does for only 1 of them? I can't tell from the code).

[vadosnaprimer]

If it shouldn't be merged yet, you can convert it to a draft.