Web Socket Implementation Fixes #3773
Open
+58
−31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Fix" for the current websocket client implementation.
To preface, the existing implementation technically worked, but had a couple undesirable behaviors, as well as some missing references:
So with that said, I made the following changes:
I've been running this, minus the maxMessages addition, for several months now without issue. specifically using StreamerBot's websocket server, and then a much less robust local server for initial testing. But happy to tweak things and make changes, of course.
Check if completed: