fix some nullability warnings

Morilli · Morilli · commit fa75f3222a9b · 2023-11-03T11:58:28.000+01:00
diff --git a/src/BizHawk.BizInvoke/BizInvoker.cs b/src/BizHawk.BizInvoke/BizInvoker.cs
@@ -584,7 +584,7 @@ private static ParameterLoadInfo EmitParamterLoad(ILGenerator il, int idx, Type
 				il.Emit(OpCodes.Brfalse, isNull);
 
 				var encoding = il.DeclareLocal(typeof(Encoding), false);
-				il.EmitCall(OpCodes.Call, typeof(Encoding).GetProperty("UTF8")!.GetGetMethod(), Type.EmptyTypes);
+				il.EmitCall(OpCodes.Call, typeof(Encoding).GetProperty("UTF8")!.GetGetMethod()!, Type.EmptyTypes);
 				il.Emit(OpCodes.Stloc, encoding);
 
 				var strlenbytes = il.DeclareLocal(typeof(int), false);
@@ -616,7 +616,7 @@ private static ParameterLoadInfo EmitParamterLoad(ILGenerator il, int idx, Type
 				il.Emit(OpCodes.Add);
 				// charcount
 				il.Emit(OpCodes.Ldloc, strval);
-				il.Emit(OpCodes.Call, typeof(string).GetProperty("Length")!.GetGetMethod());
+				il.Emit(OpCodes.Call, typeof(string).GetProperty("Length")!.GetGetMethod()!);
 				// bytes
 				il.Emit(OpCodes.Ldloc, bytes);
 				// bytelength
diff --git a/src/BizHawk.BizInvoke/BizInvokerUtilities.cs b/src/BizHawk.BizInvoke/BizInvokerUtilities.cs
@@ -58,7 +58,7 @@ private class CF
 		/// </summary>
 		/// <returns></returns>
 		public static int ComputeClassFirstFieldOffset()
-			=> ComputeFieldOffset(typeof(CF).GetField("FirstField"));
+			=> ComputeFieldOffset(typeof(CF).GetField("FirstField")!);
 
 		/// <summary>
 		/// Compute the byte offset of the first byte of string data (UTF16) relative to a pointer to the string.
diff --git a/src/BizHawk.BizInvoke/CallingConventionAdapter.cs b/src/BizHawk.BizInvoke/CallingConventionAdapter.cs
@@ -144,7 +144,7 @@ private class WaterboxAdapter : ICallingConventionAdapter
 		{
 			private class ReferenceEqualityComparer : IEqualityComparer<Delegate>
 			{
-				public bool Equals(Delegate x, Delegate y)
+				public bool Equals(Delegate? x, Delegate? y)
 					=> x == y;
 
 				public int GetHashCode(Delegate obj)
diff --git a/src/BizHawk.Client.Common/Api/Classes/CommApi.cs b/src/BizHawk.Client.Common/Api/Classes/CommApi.cs
@@ -20,6 +20,6 @@ public sealed class CommApi : ICommApi
 
 		public string? HttpTest() => HTTP == null ? null : string.Join("\n", HttpTestGet(), HTTP.SendScreenshot(), "done testing");
 
-		public string? HttpTestGet() => HTTP?.Get(HTTP.GetUrl)?.Result;
+		public string? HttpTestGet() => HttpCommunication.Get(HTTP?.GetUrl)?.Result;
 	}
 }
diff --git a/src/BizHawk.Client.Common/Api/ClientWebSocketWrapper.cs b/src/BizHawk.Client.Common/Api/ClientWebSocketWrapper.cs
@@ -32,12 +32,12 @@ public Task Close(WebSocketCloseStatus closeStatus, string statusDescription, Ca
 			return task;
 		}
 
-		/// <summary>calls <see cref="ClientWebSocket.ReceiveAsync"/></summary>
+		/// <summary>calls <see cref="ClientWebSocket.ReceiveAsync(System.ArraySegment{byte}, CancellationToken)"/></summary>
 		public Task<WebSocketReceiveResult> Receive(ArraySegment<byte> buffer, CancellationToken? cancellationToken = null)
 			=> _w?.ReceiveAsync(buffer, cancellationToken ?? CancellationToken.None)
 				?? throw new ObjectDisposedException(nameof(_w));
 
-		/// <summary>calls <see cref="ClientWebSocket.ReceiveAsync"/></summary>
+		/// <summary>calls <see cref="ClientWebSocket.ReceiveAsync(System.ArraySegment{byte}, CancellationToken)"/></summary>
 		public string Receive(int bufferCap, CancellationToken? cancellationToken = null)
 		{
 			if (_w == null) throw new ObjectDisposedException(nameof(_w));
@@ -46,12 +46,12 @@ public string Receive(int bufferCap, CancellationToken? cancellationToken = null
 			return Encoding.UTF8.GetString(buffer, 0, result.Count);
 		}
 
-		/// <summary>calls <see cref="ClientWebSocket.SendAsync"/></summary>
+		/// <summary>calls <see cref="ClientWebSocket.SendAsync(System.ArraySegment{byte}, WebSocketMessageType, bool, CancellationToken)"/></summary>
 		public Task Send(ArraySegment<byte> buffer, WebSocketMessageType messageType, bool endOfMessage, CancellationToken? cancellationToken = null)
 			=> _w?.SendAsync(buffer, messageType, endOfMessage, cancellationToken ?? CancellationToken.None)
 				?? throw new ObjectDisposedException(nameof(_w));
 
-		/// <summary>calls <see cref="ClientWebSocket.SendAsync"/></summary>
+		/// <summary>calls <see cref="ClientWebSocket.SendAsync(System.ArraySegment{byte}, WebSocketMessageType, bool, CancellationToken)"/></summary>
 		public Task Send(string message, bool endOfMessage, CancellationToken? cancellationToken = null)
 		{
 			if (_w == null) throw new ObjectDisposedException(nameof(_w));
diff --git a/src/BizHawk.Client.Common/Api/HttpCommunication.cs b/src/BizHawk.Client.Common/Api/HttpCommunication.cs
@@ -7,7 +7,7 @@ namespace BizHawk.Client.Common
 {
 	public sealed class HttpCommunication
 	{
-		private readonly HttpClient _client = new HttpClient();
+		public static readonly HttpClient Client = new HttpClient();
 
 		private readonly Func<byte[]> _takeScreenshotCallback;
 
@@ -33,24 +33,24 @@ public string ExecPost(string url = null, string payload = "") => Post(
 			new FormUrlEncodedContent(new Dictionary<string, string> { ["payload"] = payload })
 		).Result;
 
-		public async Task<string> Get(string url)
+		public static async Task<string> Get(string url)
 		{
-			_client.DefaultRequestHeaders.ConnectionClose = false;
-			var response = await _client.GetAsync(url).ConfigureAwait(false);
+			Client.DefaultRequestHeaders.ConnectionClose = false;
+			var response = await Client.GetAsync(url).ConfigureAwait(false);
 			if (response.IsSuccessStatusCode)
 			{
 				return await response.Content.ReadAsStringAsync();
 			}
 			return null;
 		}
 
-		public async Task<string> Post(string url, FormUrlEncodedContent content)
+		public static async Task<string> Post(string url, FormUrlEncodedContent content)
 		{
-			_client.DefaultRequestHeaders.ConnectionClose = true;
+			Client.DefaultRequestHeaders.ConnectionClose = true;
 			HttpResponseMessage response;
 			try
 			{
-				response = await _client.PostAsync(url, content).ConfigureAwait(false);
+				response = await Client.PostAsync(url, content).ConfigureAwait(false);
 			}
 			catch (Exception e)
 			{
@@ -87,7 +87,7 @@ public void SetTimeout(int timeout)
 
 			if (timeout != 0)
 			{
-				_client.Timeout = new TimeSpan(0, 0, 0, timeout / 1000, timeout % 1000);
+				Client.Timeout = new TimeSpan(0, 0, 0, timeout / 1000, timeout % 1000);
 				Timeout = timeout;
 			}
 		}
diff --git a/src/BizHawk.Client.EmuHawk/AVOut/FFmpegDownloaderForm.cs b/src/BizHawk.Client.EmuHawk/AVOut/FFmpegDownloaderForm.cs
@@ -160,4 +160,3 @@ private void linkLabel1_LinkClicked(object sender, LinkLabelLinkClickedEventArgs
 		}
 	}
 }
-
diff --git a/src/BizHawk.Client.EmuHawk/BizHawk.Client.EmuHawk.csproj b/src/BizHawk.Client.EmuHawk/BizHawk.Client.EmuHawk.csproj
@@ -13,7 +13,7 @@
 	</PropertyGroup>
 	<ItemGroup>
 		<PackageReference Include="System.Net.Http" Version="4.3.4" />
-		<Reference Include="System.IO.Compression" />
+		<Reference Condition="$(IsTargetingNetFramework)" Include="System.IO.Compression" />
 	</ItemGroup>
 	<ItemGroup>
 		<Reference Include="PcxFileTypePlugin.HawkQuantizer" HintPath="$(ProjectDir)../../References/PcxFileTypePlugin.HawkQuantizer.dll" Private="true" />
diff --git a/src/BizHawk.Client.EmuHawk/UpdateChecker.cs b/src/BizHawk.Client.EmuHawk/UpdateChecker.cs
@@ -90,12 +90,7 @@ private static void CheckInternal()
 
 		private static string DownloadURLAsString(string url)
 		{
-			var request = (HttpWebRequest)WebRequest.Create(url);
-			request.UserAgent = "BizHawk";
-			request.KeepAlive = false;
-			using var response = (HttpWebResponse)request.GetResponse();
-			using var responseStream = new StreamReader(response.GetResponseStream());
-			return responseStream.ReadToEnd();
+			return HttpCommunication.Get(url).Result;
 		}
 
 		private static string ValidateVersionNumberString(string versionNumber)
diff --git a/src/BizHawk.Client.EmuHawk/tools/VirtualPads/controls/VirtualPadAnalogStick.cs b/src/BizHawk.Client.EmuHawk/tools/VirtualPads/controls/VirtualPadAnalogStick.cs
@@ -78,8 +78,8 @@ public VirtualPadAnalogStick(
 			AnalogStick.ClearCallback = ClearCallback;
 			manualR.Maximum = Math.Max(RectToPolarHelper(RangeX.Max, RangeY.Max).R, RectToPolarHelper(RangeX.Min, RangeY.Min).R);
 
-			void UnsetLastFocusedNUD(object sender, EventArgs eventArgs)
-				=> setLastFocusedNUD(null, null);
+			void UnsetLastFocusedNUD(object? sender, EventArgs eventArgs)
+				=> setLastFocusedNUD(null, EventArgs.Empty);
 			ManualX.ValueChanged += ManualXY_ValueChanged;
 			ManualX.GotFocus += setLastFocusedNUD;
 			ManualX.LostFocus += UnsetLastFocusedNUD;
@@ -191,7 +191,7 @@ public void Bump(int? x, int? y)
 
 		public void SetPrevious(IController previous) => AnalogStick.SetPrevious(previous);
 
-		private void ManualXY_ValueChanged(object sender, EventArgs e)
+		private void ManualXY_ValueChanged(object? sender, EventArgs e)
 		{
 			if (_updatingFromAnalog || _updatingFromPolar) return;
 			_updatingFromXY = true;
@@ -208,7 +208,7 @@ private void ManualXY_ValueChanged(object sender, EventArgs e)
 		private void MaxManualXY_ValueChanged(object sender, EventArgs e)
 			=> AnalogStick.SetUserRange((int) MaxXNumeric.Value, (int) MaxYNumeric.Value);
 
-		private void PolarNumeric_Changed(object sender, EventArgs e)
+		private void PolarNumeric_Changed(object? sender, EventArgs e)
 		{
 			if (_updatingFromAnalog || _updatingFromXY) return;
 			_updatingFromPolar = true;
diff --git a/src/BizHawk.Common/Extensions/CollectionExtensions.cs b/src/BizHawk.Common/Extensions/CollectionExtensions.cs
@@ -203,7 +203,7 @@ public static TValue GetValueOrPutNew<TKey, TValue>(this IDictionary<TKey, TValu
 		/// I suppose it's not that important because it's called on cache miss --yoshi
 		/// </remarks>
 		public static TValue GetValueOrPutNew1<TKey, TValue>(this IDictionary<TKey, TValue> dictionary, TKey key)
-			=> dictionary.GetValueOrPut(key, static k => (TValue) Activator.CreateInstance(typeof(TValue), k));
+			=> dictionary.GetValueOrPut(key, static k => (TValue) Activator.CreateInstance(typeof(TValue), k)!);
 
 		/// <inheritdoc cref="IList{T}.IndexOf"/>
 		/// <remarks>
diff --git a/src/BizHawk.Common/PropertyGridConverters/ConstrainedFloatConverter.cs b/src/BizHawk.Common/PropertyGridConverters/ConstrainedFloatConverter.cs
@@ -12,12 +12,12 @@ namespace BizHawk.Common
 	/// </summary>
 	public class ConstrainedFloatConverter : TypeConverter
 	{
-		public override bool CanConvertFrom(ITypeDescriptorContext context, Type sourceType)
+		public override bool CanConvertFrom(ITypeDescriptorContext? context, Type sourceType)
 		{
 			return sourceType == typeof(string) || base.CanConvertFrom(context, sourceType);
 		}
 
-		public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, object value)
+		public override object ConvertFrom(ITypeDescriptorContext? context, CultureInfo? culture, object value)
 		{
 			var range = (RangeAttribute)context.Instance
 				.GetType()
@@ -40,7 +40,7 @@ public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo c
 			throw new FormatException($"Invalid value: {value}, {context.PropertyDescriptor.Name} must be a float.");
 		}
 
-		public override object ConvertTo(ITypeDescriptorContext context, CultureInfo culture, object value, Type destinationType)
+		public override object ConvertTo(ITypeDescriptorContext? context, CultureInfo? culture, object? value, Type destinationType)
 		{
 			if (destinationType == null)
 			{
diff --git a/src/BizHawk.Common/PropertyGridConverters/ConstrainedIntConverter.cs b/src/BizHawk.Common/PropertyGridConverters/ConstrainedIntConverter.cs
@@ -12,12 +12,12 @@ namespace BizHawk.Common
 	/// </summary>
 	public class ConstrainedIntConverter : TypeConverter
 	{
-		public override bool CanConvertFrom(ITypeDescriptorContext context, Type sourceType)
+		public override bool CanConvertFrom(ITypeDescriptorContext? context, Type sourceType)
 		{
 			return sourceType == typeof(string) || base.CanConvertFrom(context, sourceType);
 		}
 
-		public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, object value)
+		public override object ConvertFrom(ITypeDescriptorContext? context, CultureInfo? culture, object value)
 		{
 			var range = (RangeAttribute)context.Instance
 				.GetType()
@@ -40,7 +40,7 @@ public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo c
 			throw new FormatException($"Invalid value: {value}, {context.PropertyDescriptor.Name} must be an integer.");
 		}
 
-		public override object ConvertTo(ITypeDescriptorContext context, CultureInfo culture, object value, Type destinationType)
+		public override object ConvertTo(ITypeDescriptorContext? context, CultureInfo? culture, object? value, Type destinationType)
 		{
 			if (destinationType == null)
 			{
diff --git a/src/BizHawk.Common/PropertyGridConverters/ConstrainedStringConverter.cs b/src/BizHawk.Common/PropertyGridConverters/ConstrainedStringConverter.cs
@@ -12,12 +12,12 @@ namespace BizHawk.Common
 	/// </summary>
 	public class ConstrainedStringConverter : TypeConverter
 	{
-		public override bool CanConvertFrom(ITypeDescriptorContext context, Type sourceType)
+		public override bool CanConvertFrom(ITypeDescriptorContext? context, Type sourceType)
 		{
 			return sourceType == typeof(string) || base.CanConvertFrom(context, sourceType);
 		}
 
-		public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, object value)
+		public override object ConvertFrom(ITypeDescriptorContext? context, CultureInfo? culture, object value)
 		{
 			var maxLength = (MaxLengthAttribute)context.Instance
 				.GetType()
@@ -32,7 +32,7 @@ public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo c
 				throw new FormatException($"{context.PropertyDescriptor.Name} can not be null");
 			}
 
-			return value.ToString();
+			return value.ToString()!;
 		}
 	}
 }
diff --git a/src/BizHawk.Common/PropertyGridConverters/DescribableEnumConverter.cs b/src/BizHawk.Common/PropertyGridConverters/DescribableEnumConverter.cs
@@ -16,11 +16,11 @@ public DescribableEnumConverter(Type type) : base(type)
 			enumType = type;
 		}
 
-		public override bool CanConvertFrom(ITypeDescriptorContext context, Type srcType) => srcType == typeof(string);
+		public override bool CanConvertFrom(ITypeDescriptorContext? context, Type srcType) => srcType == typeof(string);
 
-		public override bool CanConvertTo(ITypeDescriptorContext context, Type destType) => destType == typeof(string);
+		public override bool CanConvertTo(ITypeDescriptorContext? context, Type? destType) => destType == typeof(string);
 
-		public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, object value)
+		public override object ConvertFrom(ITypeDescriptorContext? context, CultureInfo? culture, object value)
 		{
 			var valueStr = value?.ToString() ?? throw new ArgumentNullException(paramName: nameof(value));
 			return Enum.Parse(
@@ -31,7 +31,7 @@ public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo c
 			);
 		}
 
-		public override object ConvertTo(ITypeDescriptorContext context, CultureInfo culture, object value, Type destType)
+		public override object ConvertTo(ITypeDescriptorContext? context, CultureInfo? culture, object? value, Type destType)
 		{
 			var fieldName = Enum.GetName(enumType, value ?? throw new ArgumentNullException(paramName: nameof(value)));
 			if (fieldName != null)
@@ -44,17 +44,17 @@ public override object ConvertTo(ITypeDescriptorContext context, CultureInfo cul
 				}
 			}
 
-			return value.ToString();
+			return value.ToString()!;
 		}
 
-		public override StandardValuesCollection GetStandardValues(ITypeDescriptorContext context) => new(
+		public override StandardValuesCollection GetStandardValues(ITypeDescriptorContext? context) => new(
 			enumType.GetFields(BindingFlags.Public | BindingFlags.Static)
 				.Select(fi => fi.GetValue(null))
 				.ToList()
 		);
 
-		public override bool GetStandardValuesExclusive(ITypeDescriptorContext context) => true;
+		public override bool GetStandardValuesExclusive(ITypeDescriptorContext? context) => true;
 
-		public override bool GetStandardValuesSupported(ITypeDescriptorContext context) => true;
+		public override bool GetStandardValuesSupported(ITypeDescriptorContext? context) => true;
 	}
 }
diff --git a/src/BizHawk.Common/Util.cs b/src/BizHawk.Common/Util.cs
@@ -122,7 +122,7 @@ public static IEnumerable<Type> GetTypesWithoutLoadErrors(this Assembly assembly
 			}
 			catch (ReflectionTypeLoadException e)
 			{
-				return e.Types.Where(t => t != null);
+				return e.Types.Where(t => t != null)!;
 			}
 		}
 
diff --git a/src/BizHawk.Emulation.Common/Database/FirmwareID.cs b/src/BizHawk.Emulation.Common/Database/FirmwareID.cs
@@ -20,7 +20,7 @@ public FirmwareID(string system, string firmware)
 			Firmware = firmware;
 		}
 
-		public override bool Equals(object obj) => obj is FirmwareID other
+		public override bool Equals(object? obj) => obj is FirmwareID other
 			&& other.Firmware == Firmware && other.System == System;
 
 		public override int GetHashCode() => (System, Firmware).GetHashCode();
diff --git a/src/BizHawk.Emulation.Common/VSystemID.cs b/src/BizHawk.Emulation.Common/VSystemID.cs
@@ -78,7 +78,7 @@ public static class Raw
 
 		private static List<string> AllSysIDs
 			=> _allSysIDs ??= typeof(Raw).GetFields(BindingFlags.Public | BindingFlags.Static)
-				.Select(x => (string) x.GetRawConstantValue())
+				.Select(x => (string) x.GetRawConstantValue()!)
 				.Order().ToList();
 
 		/// <returns><paramref name="sysID"/> iff it's in <see cref="Raw">the valid list</see>, else <see langword="null"/></returns>

Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,7 @@ private class WaterboxAdapter : ICallingConventionAdapter`
`144`	`144`	`{`
`145`	`145`	`private class ReferenceEqualityComparer : IEqualityComparer<Delegate>`
`146`	`146`	`{`
`147`		`- public bool Equals(Delegate x, Delegate y)`
	`147`	`+ public bool Equals(Delegate? x, Delegate? y)`
`148`	`148`	`=> x == y;`
`149`	`149`
`150`	`150`	`public int GetHashCode(Delegate obj)`
Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,6 @@ public sealed class CommApi : ICommApi`
`20`	`20`
`21`	`21`	`public string? HttpTest() => HTTP == null ? null : string.Join("\n", HttpTestGet(), HTTP.SendScreenshot(), "done testing");`
`22`	`22`
`23`		`- public string? HttpTestGet() => HTTP?.Get(HTTP.GetUrl)?.Result;`
	`23`	`+ public string? HttpTestGet() => HttpCommunication.Get(HTTP?.GetUrl)?.Result;`
`24`	`24`	`}`
`25`	`25`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ namespace BizHawk.Client.Common`
`7`	`7`	`{`
`8`	`8`	`public sealed class HttpCommunication`
`9`	`9`	`{`
`10`		`- private readonly HttpClient _client = new HttpClient();`
	`10`	`+ public static readonly HttpClient Client = new HttpClient();`
`11`	`11`
`12`	`12`	`private readonly Func<byte[]> _takeScreenshotCallback;`
`13`	`13`
`@@ -33,24 +33,24 @@ public string ExecPost(string url = null, string payload = "") => Post(`
`33`	`33`	`new FormUrlEncodedContent(new Dictionary<string, string> { ["payload"] = payload })`
`34`	`34`	`).Result;`
`35`	`35`
`36`		`- public async Task<string> Get(string url)`
	`36`	`+ public static async Task<string> Get(string url)`
`37`	`37`	`{`
`38`		`- _client.DefaultRequestHeaders.ConnectionClose = false;`
`39`		`- var response = await _client.GetAsync(url).ConfigureAwait(false);`
	`38`	`+ Client.DefaultRequestHeaders.ConnectionClose = false;`
	`39`	`+ var response = await Client.GetAsync(url).ConfigureAwait(false);`
`40`	`40`	`if (response.IsSuccessStatusCode)`
`41`	`41`	`{`
`42`	`42`	`return await response.Content.ReadAsStringAsync();`
`43`	`43`	`}`
`44`	`44`	`return null;`
`45`	`45`	`}`
`46`	`46`
`47`		`- public async Task<string> Post(string url, FormUrlEncodedContent content)`
	`47`	`+ public static async Task<string> Post(string url, FormUrlEncodedContent content)`
`48`	`48`	`{`
`49`		`- _client.DefaultRequestHeaders.ConnectionClose = true;`
	`49`	`+ Client.DefaultRequestHeaders.ConnectionClose = true;`
`50`	`50`	`HttpResponseMessage response;`
`51`	`51`	`try`
`52`	`52`	`{`
`53`		`- response = await _client.PostAsync(url, content).ConfigureAwait(false);`
	`53`	`+ response = await Client.PostAsync(url, content).ConfigureAwait(false);`
`54`	`54`	`}`
`55`	`55`	`catch (Exception e)`
`56`	`56`	`{`
`@@ -87,7 +87,7 @@ public void SetTimeout(int timeout)`
`87`	`87`
`88`	`88`	`if (timeout != 0)`
`89`	`89`	`{`
`90`		`- _client.Timeout = new TimeSpan(0, 0, 0, timeout / 1000, timeout % 1000);`
	`90`	`+ Client.Timeout = new TimeSpan(0, 0, 0, timeout / 1000, timeout % 1000);`
`91`	`91`	`Timeout = timeout;`
`92`	`92`	`}`
`93`	`93`	`}`
Original file line number	Diff line number	Diff line change
`@@ -160,4 +160,3 @@ private void linkLabel1_LinkClicked(object sender, LinkLabelLinkClickedEventArgs`
`160`	`160`	`}`
`161`	`161`	`}`
`162`	`162`	`}`
`163`		`-`
Original file line number	Diff line number	Diff line change
`@@ -90,12 +90,7 @@ private static void CheckInternal()`
`90`	`90`
`91`	`91`	`private static string DownloadURLAsString(string url)`
`92`	`92`	`{`
`93`		`- var request = (HttpWebRequest)WebRequest.Create(url);`
`94`		`- request.UserAgent = "BizHawk";`
`95`		`- request.KeepAlive = false;`
`96`		`- using var response = (HttpWebResponse)request.GetResponse();`
`97`		`- using var responseStream = new StreamReader(response.GetResponseStream());`
`98`		`- return responseStream.ReadToEnd();`
	`93`	`+ return HttpCommunication.Get(url).Result;`
`99`	`94`	`}`
`100`	`95`
`101`	`96`	`private static string ValidateVersionNumberString(string versionNumber)`
Original file line number	Diff line number	Diff line change
`@@ -12,12 +12,12 @@ namespace BizHawk.Common`
`12`	`12`	`/// </summary>`
`13`	`13`	`public class ConstrainedFloatConverter : TypeConverter`
`14`	`14`	`{`
`15`		`- public override bool CanConvertFrom(ITypeDescriptorContext context, Type sourceType)`
	`15`	`+ public override bool CanConvertFrom(ITypeDescriptorContext? context, Type sourceType)`
`16`	`16`	`{`
`17`	`17`	`return sourceType == typeof(string) \|\| base.CanConvertFrom(context, sourceType);`
`18`	`18`	`}`
`19`	`19`
`20`		`- public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, object value)`
	`20`	`+ public override object ConvertFrom(ITypeDescriptorContext? context, CultureInfo? culture, object value)`
`21`	`21`	`{`
`22`	`22`	`var range = (RangeAttribute)context.Instance`
`23`	`23`	`.GetType()`
`@@ -40,7 +40,7 @@ public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo c`
`40`	`40`	`throw new FormatException($"Invalid value: {value}, {context.PropertyDescriptor.Name} must be a float.");`
`41`	`41`	`}`
`42`	`42`
`43`		`- public override object ConvertTo(ITypeDescriptorContext context, CultureInfo culture, object value, Type destinationType)`
	`43`	`+ public override object ConvertTo(ITypeDescriptorContext? context, CultureInfo? culture, object? value, Type destinationType)`
`44`	`44`	`{`
`45`	`45`	`if (destinationType == null)`
`46`	`46`	`{`
Original file line number	Diff line number	Diff line change
`@@ -16,11 +16,11 @@ public DescribableEnumConverter(Type type) : base(type)`
`16`	`16`	`enumType = type;`
`17`	`17`	`}`
`18`	`18`
`19`		`- public override bool CanConvertFrom(ITypeDescriptorContext context, Type srcType) => srcType == typeof(string);`
	`19`	`+ public override bool CanConvertFrom(ITypeDescriptorContext? context, Type srcType) => srcType == typeof(string);`
`20`	`20`
`21`		`- public override bool CanConvertTo(ITypeDescriptorContext context, Type destType) => destType == typeof(string);`
	`21`	`+ public override bool CanConvertTo(ITypeDescriptorContext? context, Type? destType) => destType == typeof(string);`
`22`	`22`
`23`		`- public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, object value)`
	`23`	`+ public override object ConvertFrom(ITypeDescriptorContext? context, CultureInfo? culture, object value)`
`24`	`24`	`{`
`25`	`25`	`var valueStr = value?.ToString() ?? throw new ArgumentNullException(paramName: nameof(value));`
`26`	`26`	`return Enum.Parse(`
`@@ -31,7 +31,7 @@ public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo c`
`31`	`31`	`);`
`32`	`32`	`}`
`33`	`33`
`34`		`- public override object ConvertTo(ITypeDescriptorContext context, CultureInfo culture, object value, Type destType)`
	`34`	`+ public override object ConvertTo(ITypeDescriptorContext? context, CultureInfo? culture, object? value, Type destType)`
`35`	`35`	`{`
`36`	`36`	`var fieldName = Enum.GetName(enumType, value ?? throw new ArgumentNullException(paramName: nameof(value)));`
`37`	`37`	`if (fieldName != null)`
`@@ -44,17 +44,17 @@ public override object ConvertTo(ITypeDescriptorContext context, CultureInfo cul`
`44`	`44`	`}`
`45`	`45`	`}`
`46`	`46`
`47`		`- return value.ToString();`
	`47`	`+ return value.ToString()!;`
`48`	`48`	`}`
`49`	`49`
`50`		`- public override StandardValuesCollection GetStandardValues(ITypeDescriptorContext context) => new(`
	`50`	`+ public override StandardValuesCollection GetStandardValues(ITypeDescriptorContext? context) => new(`
`51`	`51`	`enumType.GetFields(BindingFlags.Public \| BindingFlags.Static)`
`52`	`52`	`.Select(fi => fi.GetValue(null))`
`53`	`53`	`.ToList()`
`54`	`54`	`);`
`55`	`55`
`56`		`- public override bool GetStandardValuesExclusive(ITypeDescriptorContext context) => true;`
	`56`	`+ public override bool GetStandardValuesExclusive(ITypeDescriptorContext? context) => true;`
`57`	`57`
`58`		`- public override bool GetStandardValuesSupported(ITypeDescriptorContext context) => true;`
	`58`	`+ public override bool GetStandardValuesSupported(ITypeDescriptorContext? context) => true;`
`59`	`59`	`}`
`60`	`60`	`}`
Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ public static IEnumerable<Type> GetTypesWithoutLoadErrors(this Assembly assembly`
`122`	`122`	`}`
`123`	`123`	`catch (ReflectionTypeLoadException e)`
`124`	`124`	`{`
`125`		`- return e.Types.Where(t => t != null);`
	`125`	`+ return e.Types.Where(t => t != null)!;`
`126`	`126`	`}`
`127`	`127`	`}`
`128`	`128`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ public FirmwareID(string system, string firmware)`
`20`	`20`	`Firmware = firmware;`
`21`	`21`	`}`
`22`	`22`
`23`		`- public override bool Equals(object obj) => obj is FirmwareID other`
	`23`	`+ public override bool Equals(object? obj) => obj is FirmwareID other`
`24`	`24`	`&& other.Firmware == Firmware && other.System == System;`
`25`	`25`
`26`	`26`	`public override int GetHashCode() => (System, Firmware).GetHashCode();`