From 1e0167804463d99aa35397797258966ecc0c5b20 Mon Sep 17 00:00:00 2001 From: Travis Mcgeehan Date: Tue, 15 Aug 2023 18:36:25 -0400 Subject: [PATCH] Simplify unused out param and fix unreachable code warning --- src/BizHawk.BizInvoke/BizExvoker.cs | 2 +- src/BizHawk.Emulation.Cores/Consoles/Nintendo/3DS/Citra.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/BizHawk.BizInvoke/BizExvoker.cs b/src/BizHawk.BizInvoke/BizExvoker.cs index bf8f255261a..ebc4097863f 100644 --- a/src/BizHawk.BizInvoke/BizExvoker.cs +++ b/src/BizHawk.BizInvoke/BizExvoker.cs @@ -67,7 +67,7 @@ public DelegateStorage(Type type) foreach (var (Info, Attr) in methods) { - var delegateType = BizInvokeUtilities.CreateDelegateType(Info, Attr!.CallingConvention, typeBuilder, out MethodBuilder unused).CreateType()!; + var delegateType = BizInvokeUtilities.CreateDelegateType(Info, Attr!.CallingConvention, typeBuilder, out _).CreateType()!; DelegateTypes.Add(new StoredDelegateInfo(Info, delegateType, Attr.EntryPoint ?? Info.Name)); } StorageType = typeBuilder.CreateType()!; diff --git a/src/BizHawk.Emulation.Cores/Consoles/Nintendo/3DS/Citra.cs b/src/BizHawk.Emulation.Cores/Consoles/Nintendo/3DS/Citra.cs index b1d2b2066ba..760f9254fa8 100644 --- a/src/BizHawk.Emulation.Cores/Consoles/Nintendo/3DS/Citra.cs +++ b/src/BizHawk.Emulation.Cores/Consoles/Nintendo/3DS/Citra.cs @@ -67,8 +67,8 @@ public Citra(CoreLoadParameters lp) _supportsOpenGL43 = _openGLProvider.SupportsGLVersion(4, 3); if (!_supportsOpenGL43/* && _syncSettings.GraphicsApi == CitraSyncSettings.EGraphicsApi.OpenGL*/) { - throw new("OpenGL 4.3 is required, but it is not supported on this machine"); lp.Comm.Notify("OpenGL 4.3 is not supported on this machine, falling back to software renderer", null); + throw new("OpenGL 4.3 is required, but it is not supported on this machine"); } _glCallbackInterface.RequestGLContext = RequestGLContextCallback;