Merge branch 'TASEmulators:master' into add-gameboy-memory-callback-values

Author: roydmerkel

Directory.Packages.props

@@ -8,8 +8,7 @@
 		<PackageVersion Include="Menees.Analyzers" Version="3.0.10" />
 		<PackageVersion Include="Meziantou.Analyzer" Version="2.0.33" />
 		<PackageVersion Include="Microsoft.Bcl.HashCode" Version="1.1.1" />
-		<PackageVersion Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.4" />
-		<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.3.0" />
+		<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.8.0" />
 		<PackageVersion Include="Microsoft.CSharp" Version="4.7.0" />
 		<PackageVersion Include="Microsoft.Data.Sqlite.Core" Version="8.0.1" />
 		<PackageVersion Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.3" />

ExternalProjects/AnalyzersCommon.props

@@ -14,7 +14,6 @@
 	</PropertyGroup>
 	<ItemGroup>
 		<EditorConfigFiles Include="$(MSBuildProjectDirectory)/../Analyzers.editorconfig" />
-		<PackageReference Include="Microsoft.CodeAnalysis.Analyzers" />
 		<PackageReference Include="Microsoft.CodeAnalysis.CSharp" />
 		<Compile Include="$(MSBuildProjectDirectory)/../AnalyzersCommon/**/*.cs" />
 	</ItemGroup>

ExternalProjects/BizHawk.Analyzer/FirstOrDefaultOnStructAnalyzer.cs

@@ -1,5 +1,6 @@
 namespace BizHawk.Analyzers;
 
+using System;
 using System.Collections.Immutable;
 using System.Linq;
 
@@ -42,8 +43,13 @@ public override void Initialize(AnalysisContext context)
 					var operation = (IInvocationOperation) oac.Operation;
 					var calledSym = operation.TargetMethod.ConstructedFrom;
 					if (!(firstOrDefaultWithPredSym!.Matches(calledSym) || firstOrDefaultNoPredSym!.Matches(calledSym))) return;
-					var receiverExprType = (INamedTypeSymbol) operation.SemanticModel!.GetTypeInfo((CSharpSyntaxNode) operation.Arguments[0].Syntax)!.ConvertedType!;
-					if (receiverExprType.TypeArguments[0].IsValueType) oac.ReportDiagnostic(Diagnostic.Create(DiagUseFirstOrNull, operation.Syntax.GetLocation()));
+					var receiverExprType = operation.SemanticModel!.GetTypeInfo((CSharpSyntaxNode) operation.Arguments[0].Syntax).ConvertedType!;
+					var collectionElemType = receiverExprType switch {
+						INamedTypeSymbol nts => nts.TypeArguments[0],
+						IArrayTypeSymbol ats => ats.ElementType,
+						_ => throw new InvalidOperationException($"receiver parameter's effective type was of an unexpected kind (neither class/struct nor array): {receiverExprType}")
+					};
+					if (collectionElemType.IsValueType) oac.ReportDiagnostic(Diagnostic.Create(DiagUseFirstOrNull, operation.Syntax.GetLocation()));
 				},
 				OperationKind.Invocation);
 		});

References/BizHawk.Analyzer.dll

@@ -292,10 +292,10 @@ public static int IndexOfFrame(this IList<TasBranch> list, int frame)
 		{
 			// intentionally not using linq here because this is called many times per frame
 			int index = -1;
-			var timeStamp = DateTime.MaxValue;
+			var timeStamp = DateTime.MinValue;
 			for (int i = 0; i < list.Count; i++)
 			{
-				if (list[i].Frame == frame && list[i].TimeStamp < timeStamp)
+				if (list[i].Frame == frame && list[i].TimeStamp > timeStamp)
 				{
 					index = i;
 					timeStamp = list[i].TimeStamp;