Bug/WA-314: Input file fixes for hidden and FIXED types #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #880 +/- ##
==========================================
+ Coverage 62.95% 63.44% +0.49%
==========================================
Files 427 427
Lines 12211 12215 +4
Branches 2509 2510 +1
==========================================
+ Hits 7687 7750 +63
+ Misses 4315 4259 -56
+ Partials 209 206 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…876) * Refactored some variables and props to include proptypes * fixed linting errors
…nment (#878) * small UI change to align dropdown * linting issues fixed --------- Co-authored-by: Chandra Y <[email protected]>
shayanaijaz
approved these changes
Oct 10, 2023
edmondsgarrett
approved these changes
Oct 10, 2023
chandra-tacc
added a commit
that referenced
this pull request
Oct 10, 2023
* WA-314: Input file fixes for hidden and fixed * Task/WP-66: Refactored some variables and props to include proptypes (#876) * Refactored some variables and props to include proptypes * fixed linting errors * WP-299: Add Data Files button dropdown needs minor adjustment in alignment (#878) * small UI change to align dropdown * linting issues fixed --------- Co-authored-by: Chandra Y <[email protected]> --------- Co-authored-by: Asim Regmi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Handle file input related fixes. Apps now need hidden file input to include wrapper with app.
Related
Changes
Testing
https://cep.test/workbench/applications/opensees-sp-v35?appVersion=0.0.1
https://cep.test/workbench/applications/rstudio?appVersion=4.3
https://cep.test/workbench/applications/jupyter-hpc-mpi?appVersion=1.0.1
Unit Tests
Also included in this PR are unit tests, which check the following:
Submit a job and check the action does not have the file input for
For all other file inputs, check if:
App testing screenshots:
OpenSees:
RStudio:
Jupyter:
UI
None
Notes
I have seen usage of "FIXED" file input use case yet in apps, but that is available option in tapis.