Bug/WP-306: If input file target path is empty, do not send it to tapis

[chandra-tacc]

Overview

A recent change #857 introduced target path for input file. But, this was done only if the app definition requested for it.
When the app definition does not want this feature, the current implementation is overriding target path to "*" always. This is a regression. The production behavior is to not send targetPath back to tapis.

Related

• WP-306

Changes

The behavior in prod is to not send targetPath. This code change will match that to not send target path if it is empty (undefined, null or empty in UI). This will meet all conditions.

Testing

1.Tested OpenSees which was failing before to copy files to right location
Job parameters show no targetPath( this matches prod):

{
    "job": {
        "fileInputs": [
            {
                "name": "TCL Input Directory",
                "sourceUrl": "tapis://cloud.data/corral/tacc/aci/CEP/community/opensees-sp/examples/smallsp"
            }
        ],
        "parameterSet": {
            "appArgs": [
                {
                    "name": "TCL Script",
                    "arg": "Example.tcl"
                }
            ],
            "containerArgs": [],
            "schedulerOptions": [
                {
                    "name": "TACC Allocation",
                    "description": "The TACC allocation associated with this job execution",
                    "include": true,
                    "arg": "-A TACC-ACI"
                }
            ],
            "envVariables": []
        },
        "name": "opensees-sp-v35-0.0.1_2023-10-03T22:56:41",
        "nodeCount": 1,
        "coresPerNode": 4,
        "maxMinutes": 120,
        "archiveSystemId": "frontera",
        "archiveSystemDir": "HOST_EVAL($HOME)/tapis-jobs-archive/${JobCreateDate}/${JobName}-${JobUUID}",
        "archiveOnAppError": true,
        "appId": "opensees-sp-v35",
        "appVersion": "0.0.1",
        "execSystemId": "frontera",
        "execSystemLogicalQueue": "development"
    },
    "licenseType": null,
    "isInteractive": false
}

2. Tested extract which has target path exposed.
   The job worked

3. Tested with namd
   It matches the production behavior (compared with frontera). Output location: frontera/home1/09478/cyemparala/tapis-jobs-archive/2023-10-03Z/namd-2.14_2023-10-03T23:44:19-c9521e71-1cbc-420b-9dbb-a249d52a15c5-007

UI

No Change

Notes

Created bug WP-307 to support the default targetPath setup in app definition. We have never used it, and it needs to be tested and any changes should not break apps.

[codecov]

Codecov Report

Merging #871 (e6baf95) into main (67f4e75) will decrease coverage by 0.02%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main     #871      +/-   ##
==========================================
- Coverage   63.00%   62.98%   -0.02%     
==========================================
  Files         427      427              
  Lines       12191    12196       +5     
  Branches     2504     2506       +2     
==========================================
+ Hits         7681     7682       +1     
- Misses       4303     4306       +3     
- Partials      207      208       +1     

Flag	Coverage Δ
javascript	68.67% <25.00%> (-0.04%)	⬇️
unittests	57.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...nt/src/components/Applications/AppForm/AppForm.jsx	64.50% <0.00%> (-0.29%)	⬇️
...rc/components/Applications/AppForm/AppFormUtils.js	49.29% <33.33%> (-1.46%)	⬇️

[rstijerina]

LGTM

[shayanaijaz]

LGTM