Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/WP-211: In app form add target path text input for every file input #845

Closed
wants to merge 17 commits into from

Conversation

prithuls
Copy link

@prithuls prithuls commented Aug 3, 2023

Overview

TAPIS V3 provides a mechanism to pass in path to copy input contents into. This path is optional.
From tapis docs:
"A JobFileInput object is complete when its sourceUrl and targetPath are assigned; this provides the minimal information needed to effect a transfer. If only the sourceUrl is set, Jobs will use the simple directory or file name from the URL to automatically assign the targetPath. Specifying a targetPath as “*” results in the same automatic assignment."

Related

  • WP-211
  • App Form: Add support for "targetPath" of a fileInput

Changes

  • Add form field for target path when processing file inputs
  • When populating job data, retrieve target path info and populate it according to tapis v3 structure.

Testing

  1. Check if extract or compress app are in app tray or any other app that takes file input
  2. Check that for every field with file input, there is a Target Path for field added to the form
  3. Check with different input types - providing a name, * or empty value (results in *) work with successfully creating a job.
  4. Check if the job output matches what is expected.

UI

Input form change
Screenshot 2023-09-12 at 6 22 25 PM

Successful job submission
Screenshot 2023-09-12 at 6 22 20 PM

Job payload updated
Screenshot 2023-09-12 at 6 28 11 PM

Job output folder
Screenshot 2023-09-12 at 6 29 35 PM

Notes

Screenshot 2023-08-02 at 2 56 46 PM

TAPIS V3 doc

targetPath from app definition is added to the job submission under job.fileInputs
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #845 (8500d76) into main (9a3bf2e) will decrease coverage by 0.05%.
The diff coverage is 48.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #845      +/-   ##
==========================================
- Coverage   63.05%   63.01%   -0.05%     
==========================================
  Files         427      427              
  Lines       12131    12171      +40     
  Branches     2481     2493      +12     
==========================================
+ Hits         7649     7669      +20     
- Misses       4278     4298      +20     
  Partials      204      204              
Flag Coverage Δ
javascript 68.72% <48.78%> (-0.13%) ⬇️
unittests 57.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage
...nt/src/components/Applications/AppForm/AppForm.jsx 14.28%
...rc/components/Applications/AppForm/AppFormUtils.js 78.57%
...c/components/Applications/AppForm/AppFormSchema.js 100.00%

@rstijerina rstijerina removed the request for review from fnets August 9, 2023 15:02
@chandra-tacc chandra-tacc requested review from shayanaijaz and removed request for chandra-tacc September 12, 2023 22:56
@chandra-tacc chandra-tacc changed the title Add targetPath to job.fileInputs Task/WP-211: In app form add target path text input for every file input Sep 12, 2023
chandra-tacc and others added 15 commits September 12, 2023 19:31
---------

Co-authored-by: Sal Tijerina <[email protected]>
…ts (#847)

* Prevent other users' files from appearing in search results

* update tests

* linting

---------

Co-authored-by: Jake Rosenberg <[email protected]>
Bumps [uwsgi](https://github.com/unbit/uwsgi-docs) from 2.0.21 to 2.0.22.
- [Commits](https://github.com/unbit/uwsgi-docs/commits)

---
updated-dependencies:
- dependency-name: uwsgi
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [certifi](https://github.com/certifi/python-certifi) from 2022.12.7 to 2023.7.22.
- [Commits](certifi/python-certifi@2022.12.07...2023.07.22)

---
updated-dependencies:
- dependency-name: certifi
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* added success message and state for interactive job on timeout

* linting

* created a central utility function, added logic to determine timeout

* remove commented code

* Added a comment
* task/wp-105: create common utils function

* add check is not a string

* prettier

* run prettier

* removed null return, renamed function

* prettier

---------

Co-authored-by: Sal Tijerina <[email protected]>
@chandra-tacc
Copy link
Collaborator

opening a new PR to avoid the mess with old commits

@chandra-tacc chandra-tacc deleted the task/WP-211-support-for-targetPath-of-fileInputs branch September 13, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants