-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/WP-211: In app form add target path text input for every file input #845
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targetPath from app definition is added to the job submission under job.fileInputs
prithuls
requested review from
chandra-tacc,
fnets,
rstijerina and
edmondsgarrett
August 3, 2023 18:11
Codecov Report
@@ Coverage Diff @@
## main #845 +/- ##
==========================================
- Coverage 63.05% 63.01% -0.05%
==========================================
Files 427 427
Lines 12131 12171 +40
Branches 2481 2493 +12
==========================================
+ Hits 7649 7669 +20
- Misses 4278 4298 +20
Partials 204 204
Flags with carried forward coverage won't be shown. Click here to find out more. |
chandra-tacc
requested review from
shayanaijaz
and removed request for
chandra-tacc
September 12, 2023 22:56
chandra-tacc
changed the title
Add targetPath to job.fileInputs
Task/WP-211: In app form add target path text input for every file input
Sep 12, 2023
--------- Co-authored-by: Sal Tijerina <[email protected]>
…ts (#847) * Prevent other users' files from appearing in search results * update tests * linting --------- Co-authored-by: Jake Rosenberg <[email protected]>
Co-authored-by: Jake Rosenberg <[email protected]>
Bumps [uwsgi](https://github.com/unbit/uwsgi-docs) from 2.0.21 to 2.0.22. - [Commits](https://github.com/unbit/uwsgi-docs/commits) --- updated-dependencies: - dependency-name: uwsgi dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [certifi](https://github.com/certifi/python-certifi) from 2022.12.7 to 2023.7.22. - [Commits](certifi/python-certifi@2022.12.07...2023.07.22) --- updated-dependencies: - dependency-name: certifi dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* added success message and state for interactive job on timeout * linting * created a central utility function, added logic to determine timeout * remove commented code * Added a comment
* task/wp-105: create common utils function * add check is not a string * prettier * run prettier * removed null return, renamed function * prettier --------- Co-authored-by: Sal Tijerina <[email protected]>
opening a new PR to avoid the mess with old commits |
chandra-tacc
deleted the
task/WP-211-support-for-targetPath-of-fileInputs
branch
September 13, 2023 13:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
TAPIS V3 provides a mechanism to pass in path to copy input contents into. This path is optional.
From tapis docs:
"A JobFileInput object is complete when its sourceUrl and targetPath are assigned; this provides the minimal information needed to effect a transfer. If only the sourceUrl is set, Jobs will use the simple directory or file name from the URL to automatically assign the targetPath. Specifying a targetPath as “*” results in the same automatic assignment."
Related
Changes
Testing
UI
Input form change
Successful job submission
Job payload updated
Job output folder
Notes
TAPIS V3 doc