Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Cruft & Be Consistent #221

Open
wesleyboar opened this issue Sep 1, 2023 · 0 comments
Open

Cleanup Cruft & Be Consistent #221

wesleyboar opened this issue Sep 1, 2023 · 0 comments

Comments

@wesleyboar
Copy link
Member

wesleyboar commented Sep 1, 2023

Overview

Update all projects based on general review comments in #184.

To Do

Elasticsearch

Example: b942d2c

  • remove elasticsearch.py
  • remove elasticsearch container volume ./elasticsearch.py:…

Custom Apps

Example: a993361, f8e4640

  • remove cms container volume ./src/apps:/code/apps
  • remove Docker COPY /src/apps /code/apps
  • remove src/apps

TACC Core-Styles Version

Example: d192e40

  • add TACC_CORE_STYLES_VERSION to taccsite_cms/settings_custom.py

CMS Settings

  • make order of settings in settings_custom.py match Core-CMS

No Extra __init__.py

Example: /example_cms& /ecep-cms

  • remove extra __init__.py files (only apps need them)

Remove Placeholder Templates

Example: demdata-cms

  1. Edit all pages on a production website of a deployed Core-CMS-Custom app.
  2. Update them to not use DEPRECATED templates.
  3. Delete the ____-cms/templates directory.

Just One Images Folder

Example: 30c248

  • move images from /img/org_logos & /img/favicons to just /img
  • update settings_custom.py to use /img path, not /img/org_logos & /img/favicons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant