Skip to content

Commit 733d781

Browse files
authored
Quick Fix: APCD, List registrations for submitter is broken (#398)
* Fix syntax error in sql * move left join before where
1 parent 9c17c06 commit 733d781

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

apcd_cms/src/apps/utils/apcd_database.py

+6-5
Original file line numberDiff line numberDiff line change
@@ -177,11 +177,12 @@ def get_registrations(reg_id=None, submitter_code=None):
177177
registrations.state,
178178
registrations.zip,
179179
registrations.registration_year
180-
FROM registrations
181-
{f"WHERE registration_id = {str(reg_id)}" if reg_id is not None else ''}
182-
{f"LEFT JOIN registration_submitters on registrations.registration_id = registration_submitters.registration_id LEFT JOIN submitters ON registration_submitters.submitter_id = submitters.submitter_id WHERE submitter_code = ANY(%s) ORDER BY registrations.registration_id" if submitter_code is not None else ''}
183-
ORDER BY registrations.registration_id desc"""
184-
180+
FROM registrations
181+
{f"LEFT JOIN registration_submitters ON registrations.registration_id = registration_submitters.registration_id LEFT JOIN submitters ON registration_submitters.submitter_id = submitters.submitter_id" if submitter_code is not None else ''}
182+
WHERE 1=1
183+
{f" AND registrations.registration_id = {str(reg_id)}" if reg_id is not None else ''}
184+
{f" AND submitters.submitter_code = ANY(%s)" if submitter_code is not None else ''}
185+
ORDER BY registrations.registration_id"""
185186
cur = conn.cursor()
186187
if submitter_code:
187188
cur.execute(query, (submitter_code,))

0 commit comments

Comments
 (0)