-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tests between different SIRFImageData types #526
Milestone
Comments
@rijobro: So far as I can see |
I guess the point is to have the test in master, then merge it into the PRs above, and extend it to the other cases. |
evgueni-ovtchinnikov
added a commit
that referenced
this issue
Apr 8, 2020
* implemented ImageDataWrap class as a more OO alternative to image_as_sptr function * added simple image visualization script to src/common * corrected copyright statements in src/Synergistic/*utilities.* * started working on image conversion tests in C++ * implemented and tested conversion of ImageData to NiftiImageData<float> * tidied up show_image.py * tidied up images conversion test test_conv_img.cpp * created cSyn and cSyn/tests, moved files there * added image conversion C++ tests to be run by ctest * safeguarded against missing LAST_IN_SLICE acquisition (quick fix) * created C interface to ImageDataWrap * corrected method dot (complex return value for MR data) * interfaced == for ImageData into Python * added missing failure return to test_conv_img.cpp * merged master * removed const from get_num_enc_states argument * small stilistic correction in csirf.cpp * created Python ctests for conversion to NiftiImageData; run into conflict with NiftiImageData.__eq__ * applied a workaround to __eq__ conflict problem * applied quick fix to cover the case of synergistic code not being built * previous fix did not quite work, trying to amend * corrected the previous fix * replaced std::inner_product with dot in NiftiImageData::get_inner_product * overloaded == for ImageData in Matlab * implemented STIR-to-Nifti conversion test in Matlab * implemented Gadgetron-to-Nifti conversion test in Matlab * trying to run synergistic Matlab tests via ctest * added if(BUILD_MATLAB) to synergistic tests CMakeLists.txt * removed duplicate cSIRF_ImageData_reorient from csirf.cpp * replaced asserts with assert_validity in SIRF.ImageData * corrected #include in csirf.cpp * removed trailing blank in Gadgetron.py * trying to fix missing include build error on Travis Co-authored-by: Evgueni Ovtchinnikov <eeo@ccppetmr> Co-authored-by: Evgueni Ovtchinnikov <eeo@sirf>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
add
VoxelisedGeometryInfo::operator==
(use accuracy as in https://github.com/CCPPETMR/SIRF/blob/12d2a9dc36f63efc854e1ac5bb293e3ee6e15a1c/src/Registration/cReg/NiftiImageData.cpp#L837)write
!=
in terms of==
add
SIRFImageData::operator==
(and!=
)voxelised_geometry_info
norm(diff)/norm(arg1)< 1.E-3
add ctest in
cSynergistic
:expose to Matlab/Python and add tests there. Need to add test on norm of
as_array
as well.The text was updated successfully, but these errors were encountered: