Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cd_to_working_dir() to get_working_dir #121

Open
ashgillman opened this issue Jun 23, 2021 · 2 comments
Open

cd_to_working_dir() to get_working_dir #121

ashgillman opened this issue Jun 23, 2021 · 2 comments
Milestone

Comments

@ashgillman
Copy link
Member

To be honest, I do not see the added value of the function cd_to_working_dir as it's use is just to change directory to a directory where the user will store temporary working data. It does it in a totally opaque way and it really just wraps os.path.join + os.makedirs, we might as well just use those in the notebooks and will not have the problem.

Also the user does not seem to know where this directory is, unless he/she reads the docstring.

{exercises_data_path()}/working_folder/{subfolders[0]}/{subfolders[1]}/...

Originally posted by @paskino in #118 (comment)

@ashgillman
Copy link
Member Author

Do we want to replace all to:

os.chdir(get_working_dir())

?

@KrisThielemans
Copy link
Member

at this point in time, I wouldn't do it anymore. We can do it afterwards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants