Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI integration on all repos #1

Open
3 of 5 tasks
AliSoftware opened this issue Feb 13, 2017 · 5 comments
Open
3 of 5 tasks

Improve CI integration on all repos #1

AliSoftware opened this issue Feb 13, 2017 · 5 comments

Comments

@AliSoftware
Copy link
Contributor

AliSoftware commented Feb 13, 2017

This is a global TODO list regarding improving CI integration for all repos. Each item could be later split in separate issues (but as we're still finishing up the Great Split I didn't want to pollute with too much issues just yet, but still have a TODO list to keep things in mind)

  • Activate Danger, especially for
    • Checking the CHANGELOG entry has been added and it respects the expected format (full stop + 2 spaces)
    • Comment the PR with build warnings
  • Migrate from Travis-CI to Circle-CI
  • Separate each different steps (lint code, lint output, compile output, run unit tests…) in separate pipelines (that could be run in parallel) instead of having all the commands run one after the other in the same job. This way we can easily see which step worked and which failed
  • Make sure each failing step does make the build fail. e.g. currently failure in linting doesn't make the CI job fail so the PR is still marked green even if linting had warnings and errors
  • Make Danger push the lint warnings as a PR comment

\cc @djbe feel free to complete the list if you see anything missing

@djbe
Copy link
Member

djbe commented Feb 13, 2017

Maybe we can try to also parallelize the steps themselves, for example:

  • build files in parallel (tests and output files)
  • run tests in parallel?
  • ...

@AliSoftware AliSoftware modified the milestone: SwiftGen 4.2.1 Feb 18, 2017
@djbe
Copy link
Member

djbe commented Apr 24, 2017

From SwiftGen/SwiftGenKit#26:

  • Use danger to add a warning if a submodule does not point to master
  • Maybe something to trigger tests in related repos when needed

@djbe
Copy link
Member

djbe commented Apr 25, 2017

Saw this in slack:
https://circleci.com/docs/2.0/defining-multiple-jobs/

Would be a solution for triggering related builds using certain conditions.

@AliSoftware
Copy link
Contributor Author

Interesting indeed. Will try to discuss that with Danielle this week but could be the right solution

@djbe djbe removed this from the SwiftGen 4.2.1 milestone May 8, 2017
@djbe
Copy link
Member

djbe commented Jul 24, 2017

Note: check readme links using danger
SwiftGen/SwiftGen#318 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants