Skip to content

Commit 1b07432

Browse files
authored
fix: remove retainPVC option from house service (#18)
* Remove retainPVC option from house service Eliminated the retainPVC field from values.yaml, values.schema.json, and deployment.yaml, simplifying PVC retention policy management for the house service. * Bump chart version to 0.2.1 Updated the Helm chart version from 0.2.0 to 0.2.1 in Chart.yaml to reflect new changes or improvements.
1 parent 6545193 commit 1b07432

File tree

4 files changed

+2
-9
lines changed

4 files changed

+2
-9
lines changed

charts/self-hosted/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ description: A Helm chart for deploying SwanLab, an open-source ML experiment tr
55
icon: https://raw.githubusercontent.com/SwanHubX/charts/main/assets/icon.png
66
home: https://swanlab.cn
77
type: application
8-
version: 0.2.0
8+
version: 0.2.1
99
appVersion: 2.6.0
1010
keywords:
1111
- swanlab

charts/self-hosted/templates/swanlab-house/deployment.yaml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ metadata:
66
{{- include "swanlab.house.labels" . | nindent 4 }}
77

88
spec:
9+
serviceName: {{ include "swanlab.house.fullname" . }}
910
volumeClaimTemplates:
1011
- metadata:
1112
name: house
@@ -16,11 +17,6 @@ spec:
1617
resources:
1718
requests:
1819
storage: {{.Values.service.house.persistence.storageSize }}
19-
persistentVolumeClaimRetentionPolicy:
20-
{{- if .Values.service.house.retainPVC | eq false }}
21-
whenDeleted: Delete
22-
whenScaled: Delete
23-
{{- end }}
2420
replicas: {{ default 0 .Values.service.house.replicas }}
2521
selector:
2622
matchLabels:

charts/self-hosted/values.schema.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@
7272
"logResources": { "$ref": "#/definitions/resources" },
7373
"fbResources": { "$ref": "#/definitions/resources" },
7474
"persistence": { "$ref": "#/definitions/persistence" },
75-
"retainPVC": { "type": "boolean" },
7675
"customLabels": { "type": "object" },
7776
"customAnnotations": { "type": "object" },
7877
"customTolerations": { "type": "array" },

charts/self-hosted/values.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,6 @@ service:
104104
storageClass: ""
105105
# Volume size for the database data.
106106
storageSize: "10Gi"
107-
# Retain PVC on deletion. In the vast majority of cases, this is unnecessary.
108-
retainPVC: false
109107

110108
# Configuration of our frontend service
111109
cloud:

0 commit comments

Comments
 (0)