Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to google api endpoint #99

Open
luispabon opened this issue May 20, 2019 · 1 comment
Open

Changes to google api endpoint #99

luispabon opened this issue May 20, 2019 · 1 comment

Comments

@luispabon
Copy link

luispabon commented May 20, 2019

I just received the following from google cloud:

Hello Google Cloud Storage Customer,

We are writing to let you know that starting June 20, 2019, Cloud Storage will allow 
JSON API requests to be sent to storage.googleapis.com in addition to 
www.googleapis.com (the current endpoint).

What do I need to know?
On June 20, 2019, we will begin updating the Cloud Client Libraries and gsutil to 
use the new endpoint; storage.googleapis.com. After the update, your JSON API 
requests will start using the new endpoint.

What do I need to do?
If your production or test code doesn't check for endpoint-specific details, no 
action is required on your part.

If your production or test code checks for endpoint-specific details, you will need to 
modify them before June 20, 2019 as follows:

  * If your code checks that the ‘baseUrl’ or ‘rootUrl’ fields in the JSON API 
    Discovery document point to www.googleapis.com, you will need to modify 
    those checks to allow either storage.googleapis.com or www.googleapis.com. 
    Note that the oauth2 scopes fields in the Discovery document will not change 
    and will continue to point to www.googleapis.com.
  * If your code checks that the ‘selfLink’ field in bucket or object metadata 
    points to www.googleapis.com, you will need to modify that check to allow
    either storage.googleapis.com or www.googleapis.com.
  * If you access Cloud Storage through a firewall, you will need to ensure that 
    requests to storage.googleapis.com are allowed by your firewall rules.

I would imagine the plugin will be affected by this?

@AugustMiller
Copy link

AugustMiller commented May 22, 2019

We may have to wait for Google to start rolling out new client library versions, but the current constraint in package.json should be fine, so long as they stick to a minor version bump…

$ composer update ought to pick up the new version from Google, when it becomes available (or for just a specific package, $ composer update craftcms/google-cloud in the event you've found this via another package that uses Flysystem, like Craft CMS's storage volumes).

For clarity, here's what ~1.0 will match.

Came here to ask the same thing, so thanks for transcribing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants