Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Player CreatedAt is overwritten each time they play #273

Open
svperfecta opened this issue Aug 30, 2017 · 3 comments
Open

Bug: Player CreatedAt is overwritten each time they play #273

svperfecta opened this issue Aug 30, 2017 · 3 comments
Assignees

Comments

@svperfecta
Copy link
Contributor

It should be set the first time a match with the player is received.

@PierreAndreis PierreAndreis changed the title Bug: Player CreatedAT is overwritten each time they play Bug: Player CreatedAt is overwritten each time they play Aug 31, 2017
@cklugewicz
Copy link

cklugewicz commented Aug 31, 2017

If this is changing, there ought to be a 'lastModified' property added to { player }

@schneefux
Copy link
Contributor

Our site depends on createdAt the way it works currently.

Unlike matches, players need an attribute to compare the recency of an API object with a cached object in the database.

If you want to change createdAt's behavior, you should add updatedAt.

@svperfecta svperfecta assigned cforbes and unassigned cforbes Sep 5, 2017
@svperfecta
Copy link
Contributor Author

This is up next. The root issue is a change required to our ingest pipeline. I'm personally working on this starting tomorrow.

@svperfecta svperfecta self-assigned this Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants