Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShiftExpectationService.is_member_expected_to_do_shifts date bug #551

Open
Theophile-Madet opened this issue Sep 21, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@Theophile-Madet
Copy link
Contributor

In ShiftExpectationService.is_member_expected_to_do_shifts, we check

 if not shift_user_data.user.share_owner.is_active():

This checks if the user is active today, at the time of asking. However, is_member_expected_to_do_shifts has a date parameter. We should check if the member is active at the given date. For example using ShareOwnerQuerySet.with_status

@Theophile-Madet Theophile-Madet added the bug Something isn't working label Sep 21, 2024
@Theophile-Madet Theophile-Madet moved this to Small improvements in Tapir Roadmap Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Small improvements
Development

No branches or pull requests

1 participant