Scale a circle to make an ellipse instead of Bezier curves #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation is based on this Cairo cookbook recipe [1] that discusses drawing ellipses by scaling circles. [1]: https://www.cairographics.org/cookbook/ellipses/
|
Thanks! @punchagan |
punchagan
added a commit
to punchagan/ocaml-joy
that referenced
this pull request
Mar 11, 2024
Previously, we only rotated the center of the ellipse, similar to the circle. This commit adds a rotation field to the ellipse shape type which stores the rotation of the ellipse in radians. And we use Cairo's rotate function when rendering the ellipse. Fixes Sudha247#116 along with Sudha247#121.
punchagan
added a commit
to punchagan/ocaml-joy
that referenced
this pull request
Mar 11, 2024
Previously, we only rotated the center of the ellipse, similar to the circle. This commit adds a rotation field to the ellipse shape type which stores the rotation of the ellipse in radians. And we use Cairo's rotate function when rendering the ellipse. Fixes Sudha247#116 along with Sudha247#121.
nikochiko
pushed a commit
that referenced
this pull request
Mar 12, 2024
* Fix ellipse rotation to work correctly Previously, we only rotated the center of the ellipse, similar to the circle. This commit adds a rotation field to the ellipse shape type which stores the rotation of the ellipse in radians. And we use Cairo's rotate function when rendering the ellipse. Fixes #116 along with #121. * Add example with ellipse rotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation is based on this Cairo cookbook recipe 1 that discusses drawing ellipses by scaling circles.