Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible problem when a journal has more than one ISSN #173

Open
egonw opened this issue Mar 5, 2021 · 7 comments
Open

possible problem when a journal has more than one ISSN #173

egonw opened this issue Mar 5, 2021 · 7 comments
Assignees

Comments

@egonw
Copy link

egonw commented Mar 5, 2021

Many journals have two ISSN numbers, one for the print edition, one for the electronic edition.

@egonw
Copy link
Author

egonw commented Mar 5, 2021

This seems to be the cause why the WikiPathways bot gives fails on certain articles. It reports the pmid is not in Wikidata, but when it is, often the journal the article is published in has two ISSN numbers.

@LeMyst
Copy link
Contributor

LeMyst commented Mar 5, 2021

Hi @egonw
Do you have a code example?

@egonw
Copy link
Author

egonw commented Mar 11, 2021

Sorry for the delay. I don't have a code example, but PubMed identifier 11908751 is one for which we find this. It looks like https://github.com/SuLab/WikidataIntegrator/blob/main/wikidataintegrator/wdi_helpers/publication.py#L375-L488 is returning a None. cc @andrawaag

@egonw
Copy link
Author

egonw commented Mar 11, 2021

Oh, @andrawaag just found that that PubMed has a page(s) that could be problematic: it has one of the many possible hyphens, where as the code only supports one hyphen: https://github.com/SuLab/WikidataIntegrator/blob/main/wikidataintegrator/wdi_helpers/publication.py#L444

But I am not sure what the pass does in line https://github.com/SuLab/WikidataIntegrator/blob/main/wikidataintegrator/wdi_helpers/publication.py#L454 Would that explain why we get a None?

@egonw
Copy link
Author

egonw commented Mar 11, 2021

Sorry, that was silly of me. Wrong source (EuropePMC does use that hypen).

@andrawaag
Copy link
Collaborator

@egonw PubMed support in WDI has since been deprecated. I am currently addressing the lag in issues. Can you confirm if this issue still persists when running your bots with DOIs?

@egonw
Copy link
Author

egonw commented Jan 22, 2023

@andrawaag, can you plz assign the issue to me? I am not sure when I will have time, but then I have it on my todo list that I will revisit once a week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants