Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SaveMap service that returns a boolean and potentially consolidate Save/Load map services #268

Closed
Michael-Equi opened this issue Aug 1, 2020 · 1 comment

Comments

@Michael-Equi
Copy link
Contributor

Feature description

The service interface used to save a map should be more like the ones found in nav2 which include a boolean response indicating if it succeeded or failed. https://github.com/ros-planning/navigation2/blob/master/nav2_msgs/srv/SaveMap.srv

Also, while going through this I am curious if there is any reason why nav_msgs, nav2_msgs, and map_msgs all have their own variants of map handling services. It looks to me that they should be consolidated together including the SaveMap and LoadMap services from the navigation2 repository. If they were consolidated into common_msgs, they would be accessible to isolated slam tooolbox users as wells as navigation2 users while keeping things more unified. It looks like this discussion has happened to some degree before but SaveMap and Loadmap services did not get included in the mini-consolidation. ros2/common_interfaces#86

@SteveMacenski
Copy link
Owner

This map saver is just a convenience tool. You're welcome to call the map server yourself through that interface.

while going through this I am curious if there is any reason why nav_msgs, nav2_msgs, and map_msgs all have their own variants of map handling services

This isn't the right venue for that discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants