-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MemoryPack support #696
Comments
@aradalvand - I started working on this, but hit a brick wall: MemoryPack uses source generators, but so does Vogen. There is no way to order which source generator runs first, so MP was emitting errors because value objects were empty (i.e. they hadn't been augmented with fields/constructors etc.) This won't be a problem if the value objects are in a separate assembly. |
@SteveDunn You're right; I realized the same thing quickly after I suggested this :) |
Then we'd still be back to square one because the value objects would be considered "foreign" types that the user would have to manually write formatters for — see this other issue I created in MemoryPack's repo. |
The MessagePack is a big step forward & good enough for now; thanks for adding it. |
👍👍 I'll add the formatters as it'll still be useful for value objects in other assemblies. |
Originally posted by @aradalvand in #305 (comment)
The text was updated successfully, but these errors were encountered: