Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Alembic support #52581

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Feature] Alembic support #52581

wants to merge 2 commits into from

Conversation

maver1ck
Copy link
Contributor

@maver1ck maver1ck commented Nov 4, 2024

Why I'm doing:

Adding Alembic support for Starrocks dialect.
This depends on: sqlalchemy/alembic#1563

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: Maciek Bryński <[email protected]>
@maver1ck maver1ck changed the title Draft: Alembic support Draft: [Feature] Alembic support Nov 4, 2024
@maver1ck maver1ck changed the title Draft: [Feature] Alembic support [Feature] Alembic support Nov 5, 2024
Signed-off-by: Maciek Bryński <[email protected]>
@maver1ck
Copy link
Contributor Author

maver1ck commented Nov 5, 2024

sqlalchemy/alembic#1563 was merge so this PR is ready to review.

Copy link

github-actions bot commented Nov 5, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Nov 5, 2024

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Nov 5, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alembic support
1 participant