Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview of records if zone doesn't exist yet #3007

Open
Koopzington opened this issue Jun 12, 2024 · 7 comments
Open

Preview of records if zone doesn't exist yet #3007

Koopzington opened this issue Jun 12, 2024 · 7 comments

Comments

@Koopzington
Copy link

Could we make preview display the records that would be created even if the zone doesn't exist yet?
Right now (at least for the Hetzner DNS Provider if that's relevant) i only get to see the created records when i push and let dnscontrol automatically create the zone. It would be nice if we could review them in the preview output first though.

@tlimoncelli
Copy link
Contributor

Hi there!

I'm having difficulty reproducing this. Can you send me sample output?

Also, please include the output of dnscontrol version

Thanks!

@Koopzington
Copy link
Author

Koopzington commented Jun 19, 2024

var REG_NONE = NewRegistrar('none')
var DSP_HETZNER = NewDnsProvider('hetzner')

D('example.org', REG_NONE, DnsProvider(DSP_HETZNER),
    A('@', '127.0.0.1')
)

image
Same result with a freshly pulled 4.12.0

@tlimoncelli
Copy link
Contributor

Would you please try again with the ppreview command? I have a hunch this bug may not appear in the new code.

(ppreview is the future replacement for preview. it is a rewrite from scratch with many new features)

@Koopzington
Copy link
Author

image

@tlimoncelli
Copy link
Contributor

CC @das7pad

@das7pad
Copy link
Contributor

das7pad commented Dec 18, 2024

On the phone, I can check in detail when I'm back late next week.

@Koopzington can you try again with the latest version of dnscontrol and a different, random domain name?

@tlimoncelli
Copy link
Contributor

I just tested this with the BIND provider and I get a full preview. I wanted to verify that this isn't a global problem.

I look forward to @Koopzington 's results. I'm optimistic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants