Porkbun does not work concurrently (ppreview)
#2995
Comments
For Porkbun, it means "not verified" yet.
This error was caused by a missing error catch for JSON parsing, the real error message should be the follow, I will fill a PR for this. dnscontrol/providers/porkbun/api.go Line 157 in 32fe275 I'm not sure whether they have a hidden rate limit or something, in my test, when there are more than 3 domains in concurrently, an HTTP 503 error was thrown. <html>
<head><title>503 Service Temporarily Unavailable</title></head>
<body>
<center><h1>503 Service Temporarily Unavailable</h1></center>
<hr><center>openresty</center>
</body>
</html>I will contact the support for this, asking whether they have a rate limit or just the server crashed. |
|
I got a response from Porkbun support.
So the Porkbun provider is not supposed to work concurrently. |
|
1 per second? wow, that's pretty low. It might be useful to implement a re-try on 429 (if porkbun sends a proper 429 when the rate limit is exceeded). Even without concurrency it is possible that we would exceed that limit. |
Describe the bug
Testing the new concurrency feature (
ppreview) on domains handled by the Porkbun provider it fails to handle those:But the zone exists ... all works well when running the normal preview.
To Reproduce
dnscontrol ppreview --cmode allZone "example.com" does not exist. Can not create because "porkbun" does not implement ZoneCreatorissues.Expected behavior
For Porkbun to work concurrently.
DNS Provider
Additional context
Tested with dnscontrol v4.11.0.
I've checked the "Concurrency Verified" column in https://docs.dnscontrol.org/getting-started/providers ... but I was not sure if the ❌ means "verified & failed" or "not verified".
At least in my testing, when I use
dnscontrol ppreview --cmode all --domains example1.com,example2.comit still works (most of the time). It only starts throwing issues regularly when I test it with at least 3 different zones.CC @imlonghao (maintainer of the porkbun provider)
The text was updated successfully, but these errors were encountered: